Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Unified Diff: git_cl.py

Issue 2184643004: git cl set-commit: fix for Rietveld if cq dry run is active. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tests/git_cl_test.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: git_cl.py
diff --git a/git_cl.py b/git_cl.py
index 6a59cda52b9aa21facb9041e22bd9b86135569a7..1e2261c131943f0320a35196257102011ceadfda 100755
--- a/git_cl.py
+++ b/git_cl.py
@@ -1799,7 +1799,7 @@ class _RietveldChangelistImpl(_ChangelistCodereviewBase):
DieWithError('Cannot set-commit on private issue')
if new_state == _CQState.COMMIT:
- self.SetFlag('commit', '1')
+ self.SetFlags({'commit': '1', 'cq_dry_run': '0'})
elif new_state == _CQState.NONE:
self.SetFlags({'commit': '0', 'cq_dry_run': '0'})
else:
« no previous file with comments | « no previous file | tests/git_cl_test.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698