Issue 2184643004: git cl set-commit: fix for Rietveld if cq dry run is active.

Issue 2184643004: git cl set-commit: fix for Rietveld if cq dry run is active. (Closed)

Created:
4 years, 4 months ago by tandrii(chromium)

Modified:
4 years, 4 months ago

Reviewers:
Sergiy Byelozyorov, Michael Achenbach

CC:
chromium-reviews, tandrii+omg_git_cl_chromium.org, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master

Target Ref:
refs/heads/master

Project:
depot_tools

Visibility:
Public.

git cl set-commit: fix for Rietveld if cq dry run is active. If dry-run was active, git cl set-commit didn't actually trigger a full CQ run, but was just a no-op. TBR=machenbach@chromium.org BUG= Committed: https://chromium.googlesource.com/chromium/tools/depot_tools/+/4d843595aafd23e68d989efa47d9fa4819f8ad93

Created: 4 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -4 lines)			Patch
	M	git_cl.py	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	tests/git_cl_test.py	View		2 chunks	+3 lines, -3 lines	0 comments	Download

Total messages: 8 (3 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2184643004/1

4 years, 4 months ago (2016-07-27 15:19:37 UTC) #3

commit-bot: I haz the power

Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/tools/depot_tools/+/4d843595aafd23e68d989efa47d9fa4819f8ad93

4 years, 4 months ago (2016-07-27 15:23:00 UTC) #7

Message was sent while issue was closed.

lgtm