Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Unified Diff: chrome/browser/devtools/devtools_sanity_browsertest.cc

Issue 2184633003: Disable DevToolsSanityTest.TestWindowInitializedOnNavigateBack on Win (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/devtools/devtools_sanity_browsertest.cc
diff --git a/chrome/browser/devtools/devtools_sanity_browsertest.cc b/chrome/browser/devtools/devtools_sanity_browsertest.cc
index 8600f0060d528bed1f530bdd312993a05ec25b86..ba64c5f6b2c513c0af836f8b219d1ac21ee13f37 100644
--- a/chrome/browser/devtools/devtools_sanity_browsertest.cc
+++ b/chrome/browser/devtools/devtools_sanity_browsertest.cc
@@ -1409,8 +1409,16 @@ class MockWebUIProvider
// This tests checks that window is correctly initialized when DevTools is
// opened while navigation through history with forward and back actions.
// (crbug.com/627407)
+// Flaky on Windows. http://crbug.com/628174#c4
+#if defined(OS_WIN)
+#define MAYBE_TestWindowInitializedOnNavigateBack \
+ DISABLED_TestWindowInitializedOnNavigateBack
+#else
+#define MAYBE_TestWindowInitializedOnNavigateBack \
+ TestWindowInitializedOnNavigateBack
+#endif
IN_PROC_BROWSER_TEST_F(DevToolsSanityTest,
- TestWindowInitializedOnNavigateBack) {
+ MAYBE_TestWindowInitializedOnNavigateBack) {
TestChromeWebUIControllerFactory test_factory;
MockWebUIProvider mock_provider("dummyurl",
"<script>\n"
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698