Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Issue 2184603003: Move memory FYI slaves to memory full master and switch configs over. (Closed)

Created:
4 years, 5 months ago by benwells
Modified:
4 years, 4 months ago
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Move memory FYI slaves to memory full master and switch configs over. After this has been applied, the full master will be the real, running master and the fyi master can be removed. This also makes the memory full master a tree closer, as the point of this change is that it isn't a non-closer / fyi only master. BUG=597178 Committed: https://chromium.googlesource.com/chromium/tools/build/+/36281a7d0d221c037e3e245e0de0a79cba6f581f

Patch Set 1 #

Patch Set 2 : Update expectations #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+103 lines, -3086 lines) Patch
M masters/master.chromium.memory.full/master.cfg View 1 chunk +2 lines, -2 lines 0 comments Download
M masters/master.chromium.memory.full/slaves.cfg View 1 chunk +0 lines, -3 lines 0 comments Download
M masters/master.chromium.memory.fyi/slaves.cfg View 1 chunk +3 lines, -0 lines 0 comments Download
M masters/master.chromium/templates/announce.html View 5 chunks +5 lines, -5 lines 0 comments Download
M scripts/slave/bot_update.py View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/gatekeeper.json View 2 chunks +3 lines, -3 lines 0 comments Download
M scripts/slave/gatekeeper_trees.json View 1 chunk +0 lines, -1 line 1 comment Download
M scripts/slave/recipe_modules/chromium_swarming/api.py View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipe_modules/chromium_tests/builders.py View 2 chunks +2 lines, -2 lines 0 comments Download
A + scripts/slave/recipe_modules/chromium_tests/chromium_memory_full.py View 1 chunk +1 line, -1 line 0 comments Download
D scripts/slave/recipe_modules/chromium_tests/chromium_memory_fyi.py View 1 chunk +0 lines, -114 lines 0 comments Download
M scripts/slave/recipe_modules/chromium_tests/trybots.py View 2 chunks +3 lines, -3 lines 0 comments Download
M scripts/slave/recipes/chromium.py View 2 chunks +4 lines, -4 lines 0 comments Download
A + scripts/slave/recipes/chromium.expected/full_chromium_memory_full_Chromium_Linux_ChromeOS_MSan_Builder.json View 1 5 chunks +9 lines, -9 lines 0 comments Download
A + scripts/slave/recipes/chromium.expected/full_chromium_memory_full_Chromium_Linux_MSan_Builder.json View 1 5 chunks +9 lines, -9 lines 0 comments Download
A + scripts/slave/recipes/chromium.expected/full_chromium_memory_full_Chromium_Linux_TSan_Builder.json View 1 5 chunks +9 lines, -9 lines 0 comments Download
A + scripts/slave/recipes/chromium.expected/full_chromium_memory_full_Linux_ChromeOS_MSan_Tests.json View 1 6 chunks +8 lines, -8 lines 0 comments Download
A + scripts/slave/recipes/chromium.expected/full_chromium_memory_full_Linux_MSan_Tests.json View 1 6 chunks +8 lines, -8 lines 0 comments Download
A + scripts/slave/recipes/chromium.expected/full_chromium_memory_full_Linux_TSan_Tests.json View 1 6 chunks +8 lines, -8 lines 0 comments Download
D scripts/slave/recipes/chromium.expected/full_chromium_memory_fyi_Chromium_Linux_ChromeOS_MSan_Builder.json View 1 1 chunk +0 lines, -471 lines 0 comments Download
D scripts/slave/recipes/chromium.expected/full_chromium_memory_fyi_Chromium_Linux_MSan_Builder.json View 1 1 chunk +0 lines, -471 lines 0 comments Download
D scripts/slave/recipes/chromium.expected/full_chromium_memory_fyi_Chromium_Linux_TSan_Builder.json View 1 1 chunk +0 lines, -471 lines 0 comments Download
D scripts/slave/recipes/chromium.expected/full_chromium_memory_fyi_Linux_ChromeOS_MSan_Tests.json View 1 1 chunk +0 lines, -485 lines 0 comments Download
D scripts/slave/recipes/chromium.expected/full_chromium_memory_fyi_Linux_MSan_Tests.json View 1 1 chunk +0 lines, -485 lines 0 comments Download
D scripts/slave/recipes/chromium.expected/full_chromium_memory_fyi_Linux_TSan_Tests.json View 1 1 chunk +0 lines, -485 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/msan.json View 1 5 chunks +9 lines, -9 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/tsan.json View 1 5 chunks +9 lines, -9 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_linux_linux_chromium_chromeos_msan_rel_ng.json View 1 1 chunk +3 lines, -3 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_linux_linux_chromium_msan_rel_ng.json View 1 1 chunk +3 lines, -3 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_linux_linux_chromium_tsan_rel_ng.json View 1 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
benwells
https://codereview.chromium.org/2184603003/diff/20001/scripts/slave/gatekeeper_trees.json File scripts/slave/gatekeeper_trees.json (left): https://codereview.chromium.org/2184603003/diff/20001/scripts/slave/gatekeeper_trees.json#oldcode144 scripts/slave/gatekeeper_trees.json:144: "https://build.chromium.org/p/chromium.memory.fyi": ["*"], This is deliberately making chromium.memory.full a closer ...
4 years, 4 months ago (2016-07-28 08:14:15 UTC) #2
Dirk Pranke
lgtm. This is probably way too late, but is there a reason not to just ...
4 years, 4 months ago (2016-07-28 15:28:58 UTC) #3
Vadim Sh.
lgtm Also adding today's trooper. Landing this will probably require restarting all relevant buildbot slaves, ...
4 years, 4 months ago (2016-07-28 16:41:56 UTC) #5
Sergey Berezin
If slaves need a restart, please file a bug at g.co/bugatrooper . Thanks!
4 years, 4 months ago (2016-07-28 18:20:39 UTC) #7
benwells
On 2016/07/28 15:28:58, Dirk Pranke wrote: > lgtm. > > This is probably way too ...
4 years, 4 months ago (2016-07-29 02:00:54 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2184603003/20001
4 years, 4 months ago (2016-07-29 02:01:10 UTC) #10
commit-bot: I haz the power
4 years, 4 months ago (2016-07-29 02:06:50 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/tools/build/+/36281a7d0d221c037e3e...

Powered by Google App Engine
This is Rietveld 408576698