Revert of MIPS: Fix '[turbofan] Prevent storing signalling NaNs into holey double arrays.'

Revert of MIPS: Fix '[turbofan] Prevent storing signalling NaNs into holey double arrays.' (patchset #2 id:20001 of https://codereview.chromium.org/2171303002/ )

Reason for revert:
This bug has an error in the toolchain.gypi file, the conditions clause is repeated. This has broken the DrMemory builder - see first failing chromium build https://build.chromium.org/p/chromium.memory.fyi/builders/Chromium%20Windows%20Builder%20%28DrMemory%29/builds/17857 which included a v8 roll.

For reference the errors are:
gyp: Key 'conditions' repeated at level 11 with key path 'target_defaults.conditions.6.1.target_conditions.0.1.conditions.0.1' while reading C:\b\build\slave\drm-cr\build\src\v8\gypfiles\toolchain.gypi while reading includes of C:\b\build\slave\drm-cr\build\src\v8\src\d8.gyp

gyp: Key 'conditions' repeated at level 11 with key path 'target_defaults.conditions.6.1.target_conditions.0.1.conditions.0.1' while reading C:\b\build\slave\drm-cr\build\src\v8\gypfiles\toolchain.gypi while reading includes of C:\b\build\slave\drm-cr\build\src\v8\src\v8.gyp

gyp: Key 'conditions' repeated at level 11 with key path 'target_defaults.conditions.6.1.target_conditions.0.1.conditions.0.1' while reading C:\b\build\slave\drm-cr\build\src\v8\gypfiles\toolchain.gypi while reading includes of C:\b\build\slave\drm-cr\build\src\v8\samples\samples.gyp

Original issue's description:
> MIPS: Fix '[turbofan] Prevent storing signalling NaNs into holey double arrays.'
>
> Port 6470ddadf93594657acee02b5ce5459752928490
>
> On MIPS different signaling NaN values must be used for hardware and simulator targets, even at snapshot generation when always simulator is used.
>
> Original commit message:
> This introduces SilenceNaN operator, which makes sure that we only
> store quiet NaNs into holey arrays. We omit the NaN silencing code
> at instruction selection time if the input is an operation that
> cannot possibly produce signalling NaNs.
>
> BUG=
>
> Committed: https://crrev.com/52f2ceb052f63324050c7a098e4398f510b54763
> Cr-Commit-Position: refs/heads/master@{#38030}

TBR=jarin@chromium.org,machenbach@google.com,akos.palfi@mattakis.com,ivica.bogosavljevic@imgtec.com,marija.antic@imgtec.com,ilija.pavlovic.imgtec@gmail.com,akos.palfi@imgtec.com,machenbach@chromium.org,balazs.kilvady@imgtec.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=

TBR=machenbach

Committed: https://crrev.com/73a5db9d06051d85724b5846af3b3cb8aa97f60e
Cr-Commit-Position: refs/heads/master@{#38037}

[benwells, 2016-07-26 04:44:45]

The CQ bit was checked by benwells@chromium.org

[benwells, 2016-07-26 04:44:46]

Created Revert of MIPS: Fix '[turbofan] Prevent storing signalling NaNs into
holey double arrays.'

[commit-bot: I haz the power, 2016-07-26 04:44:50]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-26 04:44:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-26 04:44:51]

No L-G-T-M from a valid reviewer yet. 
CQ run can only be started by full committers or once the patch has
received an L-G-T-M from a full committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,
_not_ a full super star committer.
Committers are members of the group "project-v8-committers".
Note that this has nothing to do with OWNERS files.

[benwells, 2016-07-26 04:48:44]

Description was changed from

==========
Revert of MIPS: Fix '[turbofan] Prevent storing signalling NaNs into holey
double arrays.' (patchset #2 id:20001 of
https://codereview.chromium.org/2171303002/ )

Reason for revert:
This bug has an error in the toolchain.gypi file, the conditions clause is
repeated. This has broken the DrMemory builder - see first failing chromium
build
https://build.chromium.org/p/chromium.memory.fyi/builders/Chromium%20Windows%...
which included a v8 roll.

For reference the errors are:
gyp: Key 'conditions' repeated at level 11 with key path
'target_defaults.conditions.6.1.target_conditions.0.1.conditions.0.1' while
reading C:\b\build\slave\drm-cr\build\src\v8\gypfiles\toolchain.gypi while
reading includes of C:\b\build\slave\drm-cr\build\src\v8\src\d8.gyp

gyp: Key 'conditions' repeated at level 11 with key path
'target_defaults.conditions.6.1.target_conditions.0.1.conditions.0.1' while
reading C:\b\build\slave\drm-cr\build\src\v8\gypfiles\toolchain.gypi while
reading includes of C:\b\build\slave\drm-cr\build\src\v8\src\v8.gyp

gyp: Key 'conditions' repeated at level 11 with key path
'target_defaults.conditions.6.1.target_conditions.0.1.conditions.0.1' while
reading C:\b\build\slave\drm-cr\build\src\v8\gypfiles\toolchain.gypi while
reading includes of C:\b\build\slave\drm-cr\build\src\v8\samples\samples.gyp


Original issue's description:
> MIPS: Fix '[turbofan] Prevent storing signalling NaNs into holey double
arrays.'
> 
> Port 6470ddadf93594657acee02b5ce5459752928490
> 
> On MIPS different signaling NaN values must be used for hardware and simulator
targets, even at snapshot generation when always simulator is used.
> 
> Original commit message:
> This introduces SilenceNaN operator, which makes sure that we only
> store quiet NaNs into holey arrays. We omit the NaN silencing code
> at instruction selection time if the input is an operation that
> cannot possibly produce signalling NaNs.
> 
> BUG=
> 
> Committed: https://crrev.com/52f2ceb052f63324050c7a098e4398f510b54763
> Cr-Commit-Position: refs/heads/master@{#38030}

TBR=jarin@chromium.org,machenbach@google.com,akos.palfi@mattakis.com,ivica.bo...
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=
==========

to

==========
Revert of MIPS: Fix '[turbofan] Prevent storing signalling NaNs into holey
double arrays.' (patchset #2 id:20001 of
https://codereview.chromium.org/2171303002/ )

Reason for revert:
This bug has an error in the toolchain.gypi file, the conditions clause is
repeated. This has broken the DrMemory builder - see first failing chromium
build
https://build.chromium.org/p/chromium.memory.fyi/builders/Chromium%20Windows%...
which included a v8 roll.

For reference the errors are:
gyp: Key 'conditions' repeated at level 11 with key path
'target_defaults.conditions.6.1.target_conditions.0.1.conditions.0.1' while
reading C:\b\build\slave\drm-cr\build\src\v8\gypfiles\toolchain.gypi while
reading includes of C:\b\build\slave\drm-cr\build\src\v8\src\d8.gyp

gyp: Key 'conditions' repeated at level 11 with key path
'target_defaults.conditions.6.1.target_conditions.0.1.conditions.0.1' while
reading C:\b\build\slave\drm-cr\build\src\v8\gypfiles\toolchain.gypi while
reading includes of C:\b\build\slave\drm-cr\build\src\v8\src\v8.gyp

gyp: Key 'conditions' repeated at level 11 with key path
'target_defaults.conditions.6.1.target_conditions.0.1.conditions.0.1' while
reading C:\b\build\slave\drm-cr\build\src\v8\gypfiles\toolchain.gypi while
reading includes of C:\b\build\slave\drm-cr\build\src\v8\samples\samples.gyp


Original issue's description:
> MIPS: Fix '[turbofan] Prevent storing signalling NaNs into holey double
arrays.'
> 
> Port 6470ddadf93594657acee02b5ce5459752928490
> 
> On MIPS different signaling NaN values must be used for hardware and simulator
targets, even at snapshot generation when always simulator is used.
> 
> Original commit message:
> This introduces SilenceNaN operator, which makes sure that we only
> store quiet NaNs into holey arrays. We omit the NaN silencing code
> at instruction selection time if the input is an operation that
> cannot possibly produce signalling NaNs.
> 
> BUG=
> 
> Committed: https://crrev.com/52f2ceb052f63324050c7a098e4398f510b54763
> Cr-Commit-Position: refs/heads/master@{#38030}

TBR=jarin@chromium.org,machenbach@google.com,akos.palfi@mattakis.com,ivica.bo...
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=

TBR=machenbach
==========

[benwells, 2016-07-26 04:49:28]

On 2016/07/26 04:44:51, commit-bot: I haz the power wrote:
> No L-G-T-M from a valid reviewer yet. 
> CQ run can only be started by full committers or once the patch has
> received an L-G-T-M from a full committer.
> Even if an L-G-T-M may have been provided, it was from a non-committer,
> _not_ a full super star committer.
> Committers are members of the group "project-v8-committers".
> Note that this has nothing to do with OWNERS files.

This probably won't work, but trying with TBR...

[benwells, 2016-07-26 04:52:16]

The CQ bit was checked by benwells@chromium.org

[commit-bot: I haz the power, 2016-07-26 04:52:21]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-26 04:52:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-26 04:52:23]

No L-G-T-M from a valid reviewer yet. 
CQ run can only be started by full committers or once the patch has
received an L-G-T-M from a full committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,
_not_ a full super star committer.
Committers are members of the group "project-v8-committers".
Note that this has nothing to do with OWNERS files.

[benwells, 2016-07-26 04:58:17]

On 2016/07/26 04:52:23, commit-bot: I haz the power wrote:
> No L-G-T-M from a valid reviewer yet. 
> CQ run can only be started by full committers or once the patch has
> received an L-G-T-M from a full committer.
> Even if an L-G-T-M may have been provided, it was from a non-committer,
> _not_ a full super star committer.
> Committers are members of the group "project-v8-committers".
> Note that this has nothing to do with OWNERS files.

Will revert the roll instead.

[Michael Achenbach, 2016-07-26 06:30:37]

lgtm

[Michael Achenbach, 2016-07-26 06:30:54]

The CQ bit was checked by machenbach@chromium.org

[commit-bot: I haz the power, 2016-07-26 06:31:01]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-26 06:31:16]

Description was changed from

==========
Revert of MIPS: Fix '[turbofan] Prevent storing signalling NaNs into holey
double arrays.' (patchset #2 id:20001 of
https://codereview.chromium.org/2171303002/ )

Reason for revert:
This bug has an error in the toolchain.gypi file, the conditions clause is
repeated. This has broken the DrMemory builder - see first failing chromium
build
https://build.chromium.org/p/chromium.memory.fyi/builders/Chromium%20Windows%...
which included a v8 roll.

For reference the errors are:
gyp: Key 'conditions' repeated at level 11 with key path
'target_defaults.conditions.6.1.target_conditions.0.1.conditions.0.1' while
reading C:\b\build\slave\drm-cr\build\src\v8\gypfiles\toolchain.gypi while
reading includes of C:\b\build\slave\drm-cr\build\src\v8\src\d8.gyp

gyp: Key 'conditions' repeated at level 11 with key path
'target_defaults.conditions.6.1.target_conditions.0.1.conditions.0.1' while
reading C:\b\build\slave\drm-cr\build\src\v8\gypfiles\toolchain.gypi while
reading includes of C:\b\build\slave\drm-cr\build\src\v8\src\v8.gyp

gyp: Key 'conditions' repeated at level 11 with key path
'target_defaults.conditions.6.1.target_conditions.0.1.conditions.0.1' while
reading C:\b\build\slave\drm-cr\build\src\v8\gypfiles\toolchain.gypi while
reading includes of C:\b\build\slave\drm-cr\build\src\v8\samples\samples.gyp


Original issue's description:
> MIPS: Fix '[turbofan] Prevent storing signalling NaNs into holey double
arrays.'
> 
> Port 6470ddadf93594657acee02b5ce5459752928490
> 
> On MIPS different signaling NaN values must be used for hardware and simulator
targets, even at snapshot generation when always simulator is used.
> 
> Original commit message:
> This introduces SilenceNaN operator, which makes sure that we only
> store quiet NaNs into holey arrays. We omit the NaN silencing code
> at instruction selection time if the input is an operation that
> cannot possibly produce signalling NaNs.
> 
> BUG=
> 
> Committed: https://crrev.com/52f2ceb052f63324050c7a098e4398f510b54763
> Cr-Commit-Position: refs/heads/master@{#38030}

TBR=jarin@chromium.org,machenbach@google.com,akos.palfi@mattakis.com,ivica.bo...
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=

TBR=machenbach
==========

to

==========
Revert of MIPS: Fix '[turbofan] Prevent storing signalling NaNs into holey
double arrays.' (patchset #2 id:20001 of
https://codereview.chromium.org/2171303002/ )

Reason for revert:
This bug has an error in the toolchain.gypi file, the conditions clause is
repeated. This has broken the DrMemory builder - see first failing chromium
build
https://build.chromium.org/p/chromium.memory.fyi/builders/Chromium%20Windows%...
which included a v8 roll.

For reference the errors are:
gyp: Key 'conditions' repeated at level 11 with key path
'target_defaults.conditions.6.1.target_conditions.0.1.conditions.0.1' while
reading C:\b\build\slave\drm-cr\build\src\v8\gypfiles\toolchain.gypi while
reading includes of C:\b\build\slave\drm-cr\build\src\v8\src\d8.gyp

gyp: Key 'conditions' repeated at level 11 with key path
'target_defaults.conditions.6.1.target_conditions.0.1.conditions.0.1' while
reading C:\b\build\slave\drm-cr\build\src\v8\gypfiles\toolchain.gypi while
reading includes of C:\b\build\slave\drm-cr\build\src\v8\src\v8.gyp

gyp: Key 'conditions' repeated at level 11 with key path
'target_defaults.conditions.6.1.target_conditions.0.1.conditions.0.1' while
reading C:\b\build\slave\drm-cr\build\src\v8\gypfiles\toolchain.gypi while
reading includes of C:\b\build\slave\drm-cr\build\src\v8\samples\samples.gyp


Original issue's description:
> MIPS: Fix '[turbofan] Prevent storing signalling NaNs into holey double
arrays.'
> 
> Port 6470ddadf93594657acee02b5ce5459752928490
> 
> On MIPS different signaling NaN values must be used for hardware and simulator
targets, even at snapshot generation when always simulator is used.
> 
> Original commit message:
> This introduces SilenceNaN operator, which makes sure that we only
> store quiet NaNs into holey arrays. We omit the NaN silencing code
> at instruction selection time if the input is an operation that
> cannot possibly produce signalling NaNs.
> 
> BUG=
> 
> Committed: https://crrev.com/52f2ceb052f63324050c7a098e4398f510b54763
> Cr-Commit-Position: refs/heads/master@{#38030}

TBR=jarin@chromium.org,machenbach@google.com,akos.palfi@mattakis.com,ivica.bo...
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=

TBR=machenbach
==========

[commit-bot: I haz the power, 2016-07-26 06:31:17]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-07-26 06:32:26]

Description was changed from

==========
Revert of MIPS: Fix '[turbofan] Prevent storing signalling NaNs into holey
double arrays.' (patchset #2 id:20001 of
https://codereview.chromium.org/2171303002/ )

Reason for revert:
This bug has an error in the toolchain.gypi file, the conditions clause is
repeated. This has broken the DrMemory builder - see first failing chromium
build
https://build.chromium.org/p/chromium.memory.fyi/builders/Chromium%20Windows%...
which included a v8 roll.

For reference the errors are:
gyp: Key 'conditions' repeated at level 11 with key path
'target_defaults.conditions.6.1.target_conditions.0.1.conditions.0.1' while
reading C:\b\build\slave\drm-cr\build\src\v8\gypfiles\toolchain.gypi while
reading includes of C:\b\build\slave\drm-cr\build\src\v8\src\d8.gyp

gyp: Key 'conditions' repeated at level 11 with key path
'target_defaults.conditions.6.1.target_conditions.0.1.conditions.0.1' while
reading C:\b\build\slave\drm-cr\build\src\v8\gypfiles\toolchain.gypi while
reading includes of C:\b\build\slave\drm-cr\build\src\v8\src\v8.gyp

gyp: Key 'conditions' repeated at level 11 with key path
'target_defaults.conditions.6.1.target_conditions.0.1.conditions.0.1' while
reading C:\b\build\slave\drm-cr\build\src\v8\gypfiles\toolchain.gypi while
reading includes of C:\b\build\slave\drm-cr\build\src\v8\samples\samples.gyp


Original issue's description:
> MIPS: Fix '[turbofan] Prevent storing signalling NaNs into holey double
arrays.'
> 
> Port 6470ddadf93594657acee02b5ce5459752928490
> 
> On MIPS different signaling NaN values must be used for hardware and simulator
targets, even at snapshot generation when always simulator is used.
> 
> Original commit message:
> This introduces SilenceNaN operator, which makes sure that we only
> store quiet NaNs into holey arrays. We omit the NaN silencing code
> at instruction selection time if the input is an operation that
> cannot possibly produce signalling NaNs.
> 
> BUG=
> 
> Committed: https://crrev.com/52f2ceb052f63324050c7a098e4398f510b54763
> Cr-Commit-Position: refs/heads/master@{#38030}

TBR=jarin@chromium.org,machenbach@google.com,akos.palfi@mattakis.com,ivica.bo...
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=

TBR=machenbach
==========

to

==========
Revert of MIPS: Fix '[turbofan] Prevent storing signalling NaNs into holey
double arrays.' (patchset #2 id:20001 of
https://codereview.chromium.org/2171303002/ )

Reason for revert:
This bug has an error in the toolchain.gypi file, the conditions clause is
repeated. This has broken the DrMemory builder - see first failing chromium
build
https://build.chromium.org/p/chromium.memory.fyi/builders/Chromium%20Windows%...
which included a v8 roll.

For reference the errors are:
gyp: Key 'conditions' repeated at level 11 with key path
'target_defaults.conditions.6.1.target_conditions.0.1.conditions.0.1' while
reading C:\b\build\slave\drm-cr\build\src\v8\gypfiles\toolchain.gypi while
reading includes of C:\b\build\slave\drm-cr\build\src\v8\src\d8.gyp

gyp: Key 'conditions' repeated at level 11 with key path
'target_defaults.conditions.6.1.target_conditions.0.1.conditions.0.1' while
reading C:\b\build\slave\drm-cr\build\src\v8\gypfiles\toolchain.gypi while
reading includes of C:\b\build\slave\drm-cr\build\src\v8\src\v8.gyp

gyp: Key 'conditions' repeated at level 11 with key path
'target_defaults.conditions.6.1.target_conditions.0.1.conditions.0.1' while
reading C:\b\build\slave\drm-cr\build\src\v8\gypfiles\toolchain.gypi while
reading includes of C:\b\build\slave\drm-cr\build\src\v8\samples\samples.gyp

Original issue's description:
> MIPS: Fix '[turbofan] Prevent storing signalling NaNs into holey double
arrays.'
>
> Port 6470ddadf93594657acee02b5ce5459752928490
>
> On MIPS different signaling NaN values must be used for hardware and simulator
targets, even at snapshot generation when always simulator is used.
>
> Original commit message:
> This introduces SilenceNaN operator, which makes sure that we only
> store quiet NaNs into holey arrays. We omit the NaN silencing code
> at instruction selection time if the input is an operation that
> cannot possibly produce signalling NaNs.
>
> BUG=
>
> Committed: https://crrev.com/52f2ceb052f63324050c7a098e4398f510b54763
> Cr-Commit-Position: refs/heads/master@{#38030}

TBR=jarin@chromium.org,machenbach@google.com,akos.palfi@mattakis.com,ivica.bo...
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=

TBR=machenbach

Committed: https://crrev.com/73a5db9d06051d85724b5846af3b3cb8aa97f60e
Cr-Commit-Position: refs/heads/master@{#38037}
==========

[commit-bot: I haz the power, 2016-07-26 06:32:27]

Patchset 1 (id:??) landed as
https://crrev.com/73a5db9d06051d85724b5846af3b3cb8aa97f60e
Cr-Commit-Position: refs/heads/master@{#38037}