Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Unified Diff: test/runner/configuration/configuration_test.dart

Issue 2184543002: Use the package_resolver package. (Closed) Base URL: git@github.com:dart-lang/test@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « test/runner/browser/loader_test.dart ('k') | test/runner/loader_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/runner/configuration/configuration_test.dart
diff --git a/test/runner/configuration/configuration_test.dart b/test/runner/configuration/configuration_test.dart
index 2a4a2e088da78aa32a9c73bc63ce998ffafc48e9..92c824d86b05edde721e5884345e50ebcbb3588a 100644
--- a/test/runner/configuration/configuration_test.dart
+++ b/test/runner/configuration/configuration_test.dart
@@ -30,7 +30,6 @@ void main() {
expect(merged.color, equals(canUseSpecialChars));
expect(merged.shardIndex, isNull);
expect(merged.totalShards, isNull);
- expect(merged.packageRoot, equals(p.join(p.current, 'packages')));
expect(merged.dart2jsPath, equals(p.join(sdkDir, 'bin', 'dart2js')));
expect(merged.precompiledPath, isNull);
expect(merged.reporter, equals(defaultReporter));
@@ -52,7 +51,6 @@ void main() {
color: true,
shardIndex: 3,
totalShards: 10,
- packageRoot: "root",
dart2jsPath: "/tmp/dart2js",
precompiledPath: "/tmp/js",
reporter: "json",
@@ -72,7 +70,6 @@ void main() {
expect(merged.color, isTrue);
expect(merged.shardIndex, equals(3));
expect(merged.totalShards, equals(10));
- expect(merged.packageRoot, equals("root"));
expect(merged.dart2jsPath, equals("/tmp/dart2js"));
expect(merged.precompiledPath, equals("/tmp/js"));
expect(merged.reporter, equals("json"));
@@ -94,7 +91,6 @@ void main() {
color: true,
shardIndex: 3,
totalShards: 10,
- packageRoot: "root",
dart2jsPath: "/tmp/dart2js",
precompiledPath: "/tmp/js",
reporter: "json",
@@ -113,7 +109,6 @@ void main() {
expect(merged.color, isTrue);
expect(merged.shardIndex, equals(3));
expect(merged.totalShards, equals(10));
- expect(merged.packageRoot, equals("root"));
expect(merged.dart2jsPath, equals("/tmp/dart2js"));
expect(merged.precompiledPath, equals("/tmp/js"));
expect(merged.reporter, equals("json"));
@@ -136,7 +131,6 @@ void main() {
color: false,
shardIndex: 2,
totalShards: 4,
- packageRoot: "root",
dart2jsPath: "/tmp/dart2js",
precompiledPath: "/tmp/js",
reporter: "json",
@@ -155,7 +149,6 @@ void main() {
color: true,
shardIndex: 3,
totalShards: 10,
- packageRoot: "boot",
dart2jsPath: "../dart2js",
precompiledPath: "../js",
reporter: "compact",
@@ -174,7 +167,6 @@ void main() {
expect(merged.color, isTrue);
expect(merged.shardIndex, equals(3));
expect(merged.totalShards, equals(10));
- expect(merged.packageRoot, equals("boot"));
expect(merged.dart2jsPath, equals("../dart2js"));
expect(merged.precompiledPath, equals("../js"));
expect(merged.reporter, equals("compact"));
« no previous file with comments | « test/runner/browser/loader_test.dart ('k') | test/runner/loader_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698