Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1488)

Unified Diff: lib/src/util/stack_trace_mapper.dart

Issue 2184543002: Use the package_resolver package. (Closed) Base URL: git@github.com:dart-lang/test@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « lib/src/util/io.dart ('k') | pubspec.yaml » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/src/util/stack_trace_mapper.dart
diff --git a/lib/src/util/stack_trace_mapper.dart b/lib/src/util/stack_trace_mapper.dart
index a50c75ee2680a6be027e65080da457e8111841d1..04390fadbe3280c1b4582face225f988e2447898 100644
--- a/lib/src/util/stack_trace_mapper.dart
+++ b/lib/src/util/stack_trace_mapper.dart
@@ -2,6 +2,7 @@
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
+import 'package:package_resolver/package_resolver.dart';
import 'package:source_map_stack_trace/source_map_stack_trace.dart' as mapper;
import 'package:source_maps/source_maps.dart';
@@ -10,19 +11,20 @@ class StackTraceMapper {
/// The parsed source map.
final Mapping _mapping;
- /// The URI of the package root, as passed to dart2js.
- final Uri _packageRoot;
+ /// The package resolution information passed to dart2js.
+ final SyncPackageResolver _packageResolver;
/// The URI of the SDK root from which dart2js loaded its sources.
final Uri _sdkRoot;
- StackTraceMapper(String contents, {Uri mapUrl, Uri packageRoot, Uri sdkRoot})
+ StackTraceMapper(String contents, {Uri mapUrl,
+ SyncPackageResolver packageResolver, Uri sdkRoot})
: _mapping = parse(contents, mapUrl: mapUrl),
- _packageRoot = packageRoot,
+ _packageResolver = packageResolver,
_sdkRoot = sdkRoot;
/// Converts [trace] into a Dart stack trace.
StackTrace mapStackTrace(StackTrace trace) =>
mapper.mapStackTrace(_mapping, trace,
- packageRoot: _packageRoot, sdkRoot: _sdkRoot);
+ packageResolver: _packageResolver, sdkRoot: _sdkRoot);
}
« no previous file with comments | « lib/src/util/io.dart ('k') | pubspec.yaml » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698