Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Unified Diff: lib/src/runner/configuration.dart

Issue 2184543002: Use the package_resolver package. (Closed) Base URL: git@github.com:dart-lang/test@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « lib/src/runner/browser/platform.dart ('k') | lib/src/runner/configuration/args.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/src/runner/configuration.dart
diff --git a/lib/src/runner/configuration.dart b/lib/src/runner/configuration.dart
index 321a4066e9d1099a628514ebf27f025e3e3cae4d..e31b06660429a5f396b19becb2719391ad0a12cb 100644
--- a/lib/src/runner/configuration.dart
+++ b/lib/src/runner/configuration.dart
@@ -68,10 +68,6 @@ class Configuration {
bool get pauseAfterLoad => _pauseAfterLoad ?? false;
final bool _pauseAfterLoad;
- /// The package root for resolving "package:" URLs.
- String get packageRoot => _packageRoot ?? p.join(p.current, 'packages');
- final String _packageRoot;
-
/// The path to dart2js.
String get dart2jsPath => _dart2jsPath ?? p.join(sdkDir, 'bin', 'dart2js');
final String _dart2jsPath;
@@ -283,7 +279,6 @@ class Configuration {
PlatformSelector testOn,
bool pauseAfterLoad,
bool color,
- String packageRoot,
String dart2jsPath,
Iterable<String> dart2jsArgs,
String precompiledPath,
@@ -315,7 +310,6 @@ class Configuration {
testOn: testOn,
pauseAfterLoad: pauseAfterLoad,
color: color,
- packageRoot: packageRoot,
dart2jsPath: dart2jsPath,
dart2jsArgs: dart2jsArgs,
precompiledPath: precompiledPath,
@@ -386,7 +380,6 @@ class Configuration {
PlatformSelector testOn,
bool pauseAfterLoad,
bool color,
- String packageRoot,
String dart2jsPath,
Iterable<String> dart2jsArgs,
this.precompiledPath,
@@ -416,7 +409,6 @@ class Configuration {
testOn = testOn ?? PlatformSelector.all,
_pauseAfterLoad = pauseAfterLoad,
_color = color,
- _packageRoot = packageRoot,
_dart2jsPath = dart2jsPath,
dart2jsArgs = dart2jsArgs?.toList() ?? [],
_reporter = reporter,
@@ -491,7 +483,6 @@ class Configuration {
testOn: testOn.intersection(other.testOn),
pauseAfterLoad: other._pauseAfterLoad ?? _pauseAfterLoad,
color: other._color ?? _color,
- packageRoot: other._packageRoot ?? _packageRoot,
dart2jsPath: other._dart2jsPath ?? _dart2jsPath,
dart2jsArgs: dart2jsArgs.toList()..addAll(other.dart2jsArgs),
precompiledPath: other.precompiledPath ?? precompiledPath,
@@ -534,7 +525,6 @@ class Configuration {
PlatformSelector testOn,
bool pauseAfterLoad,
bool color,
- String packageRoot,
String dart2jsPath,
Iterable<String> dart2jsArgs,
String precompiledPath,
@@ -566,7 +556,6 @@ class Configuration {
testOn: testOn ?? this.testOn,
pauseAfterLoad: pauseAfterLoad ?? _pauseAfterLoad,
color: color ?? _color,
- packageRoot: packageRoot ?? _packageRoot,
dart2jsPath: dart2jsPath ?? _dart2jsPath,
dart2jsArgs: dart2jsArgs?.toList() ?? this.dart2jsArgs,
precompiledPath: precompiledPath ?? this.precompiledPath,
« no previous file with comments | « lib/src/runner/browser/platform.dart ('k') | lib/src/runner/configuration/args.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698