Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1091)

Unified Diff: src/compiler/js-typed-lowering.cc

Issue 2184513003: [turbofan] Adds handling of number or oddball type feedback to SpeculativeNumberShiftLeft. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/compiler/representation-change.h » ('j') | src/compiler/representation-change.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/compiler/js-typed-lowering.cc
diff --git a/src/compiler/js-typed-lowering.cc b/src/compiler/js-typed-lowering.cc
index a88658c408eed258899ff31448f2a6e9620a8f8c..a3d36dd6a03798a47ddabfd6532f66359f731b04 100644
--- a/src/compiler/js-typed-lowering.cc
+++ b/src/compiler/js-typed-lowering.cc
@@ -596,7 +596,8 @@ Reduction JSTypedLowering::ReduceShiftLeft(Node* node) {
JSBinopReduction r(this, node);
BinaryOperationHints::Hint feedback = r.GetNumberBinaryOperationFeedback();
if (feedback == BinaryOperationHints::kSigned32 ||
Benedikt Meurer 2016/07/27 03:34:36 Nit: use feedback != BinaryOperationHints::kAny as
epertoso 2016/07/27 08:26:36 Done.
- feedback == BinaryOperationHints::kSignedSmall) {
+ feedback == BinaryOperationHints::kSignedSmall ||
+ feedback == BinaryOperationHints::kNumberOrOddball) {
return r.ChangeToSpeculativeOperator(
simplified()->SpeculativeNumberShiftLeft(feedback), Type::Signed32());
}
« no previous file with comments | « no previous file | src/compiler/representation-change.h » ('j') | src/compiler/representation-change.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698