Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(275)

Issue 2184503003: Convert editing/inserting/typing-00[1-3].html to use w3c test harness (Closed)

Created:
4 years, 4 months ago by yosin_UTC9
Modified:
4 years, 4 months ago
Reviewers:
yoichio, Xiaocheng
CC:
blink-reviews, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert editing/inserting/typing-00[1-3].html to use w3c test harness This patch converts "editing/inserting/typing-00[1-3].html" to use w3c test harness and consolidates into "typing.html" to simplify test case for ease of maintenance. This patch is a preparation of getting rid of grammar checking feature. BUG=619452 TEST=n/a; this patch changes a test file Committed: https://crrev.com/52e039ba69a827512936f7a9146578560778e519 Cr-Commit-Position: refs/heads/master@{#407732}

Patch Set 1 : 2016-07-26T14:42:22 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -1931 lines) Patch
A third_party/WebKit/LayoutTests/editing/inserting/typing.html View 1 chunk +48 lines, -0 lines 0 comments Download
D third_party/WebKit/LayoutTests/editing/inserting/typing-001.html View 1 chunk +0 lines, -47 lines 0 comments Download
D third_party/WebKit/LayoutTests/editing/inserting/typing-002.html View 1 chunk +0 lines, -42 lines 0 comments Download
D third_party/WebKit/LayoutTests/editing/inserting/typing-003.html View 1 chunk +0 lines, -84 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/editing/inserting/typing-001-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/editing/inserting/typing-001-expected.txt View 1 chunk +0 lines, -33 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/editing/inserting/typing-002-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/editing/inserting/typing-002-expected.txt View 1 chunk +0 lines, -25 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/editing/inserting/typing-003-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/editing/inserting/typing-003-expected.txt View 1 chunk +0 lines, -528 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/editing/inserting/typing-001-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/editing/inserting/typing-001-expected.txt View 1 chunk +0 lines, -33 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/editing/inserting/typing-002-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/editing/inserting/typing-002-expected.txt View 1 chunk +0 lines, -25 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/editing/inserting/typing-003-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/editing/inserting/typing-003-expected.txt View 1 chunk +0 lines, -528 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/editing/inserting/typing-001-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/editing/inserting/typing-001-expected.txt View 1 chunk +0 lines, -33 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/editing/inserting/typing-002-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/editing/inserting/typing-002-expected.txt View 1 chunk +0 lines, -25 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/editing/inserting/typing-003-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/editing/inserting/typing-003-expected.txt View 1 chunk +0 lines, -528 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
yosin_UTC9
PTAL
4 years, 4 months ago (2016-07-26 06:29:21 UTC) #5
Xiaocheng
lgtm
4 years, 4 months ago (2016-07-26 07:09:48 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2184503003/1
4 years, 4 months ago (2016-07-26 07:18:29 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-07-26 07:50:35 UTC) #10
commit-bot: I haz the power
4 years, 4 months ago (2016-07-26 07:53:10 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/52e039ba69a827512936f7a9146578560778e519
Cr-Commit-Position: refs/heads/master@{#407732}

Powered by Google App Engine
This is Rietveld 408576698