Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2184503002: Disable Many AppBannerDataFetcherBrowserTest Failing Tests (Closed)

Created:
4 years, 5 months ago by Mark P
Modified:
4 years, 5 months ago
Reviewers:
CC:
chromium-reviews, dominickn+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable Many AppBannerDataFetcherBrowserTest Failing Tests TBR=dominickn@chromium.org BUG=631190 Committed: https://crrev.com/3429dff80be28f18b66b7d93718d131dc4aea9de Cr-Commit-Position: refs/heads/master@{#407653}

Patch Set 1 #

Patch Set 2 : Disable Many AppBannerDataFetcherBrowserTest Failing Tests #

Patch Set 3 : forgot one #

Unified diffs Side-by-side diffs Delta from patch set Stats (+122 lines, -17 lines) Patch
M chrome/browser/banners/app_banner_data_fetcher_browsertest.cc View 1 2 6 chunks +122 lines, -17 lines 0 comments Download

Messages

Total messages: 10 (6 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2184503002/40001
4 years, 5 months ago (2016-07-25 23:36:51 UTC) #5
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 5 months ago (2016-07-26 00:40:53 UTC) #7
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/3429dff80be28f18b66b7d93718d131dc4aea9de Cr-Commit-Position: refs/heads/master@{#407653}
4 years, 5 months ago (2016-07-26 00:42:01 UTC) #9
dominickn
4 years, 5 months ago (2016-07-26 05:45:59 UTC) #10
Message was sent while issue was closed. 
A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/2185483002/ by dominickn@chromium.org.

The reason for reverting is: Speculative revert to see if reverting
crrev.com/2183783002 fixes the failing tests in crbug.com/631190.

App banners use methods touched by that CL to check if a service worker is
registered.

This CL will be relanded if the re-enabled tests still fail on
https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%2....

Powered by Google App Engine
This is Rietveld 408576698