Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(695)

Issue 2184483003: Move SkJSONCPP.h to tools. It tool-only. (Closed)

Created:
4 years, 4 months ago by mtklein_C
Modified:
4 years, 4 months ago
Reviewers:
jcgregorio
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Move SkJSONCPP.h to tools. It tool-only. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2184483003 CQ_INCLUDE_TRYBOTS=master.client.skia.compile:Build-Ubuntu-GCC-x86_64-Release-CMake-Trybot,Build-Mac-Clang-x86_64-Release-CMake-Trybot TBR=reed@google.com Committed: https://skia.googlesource.com/skia/+/1b51e0ec466026794f96e2c476f0c7f9db0f13dc

Patch Set 1 #

Patch Set 2 : update cmake #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -33 lines) Patch
M cmake/CMakeLists.txt View 1 1 chunk +1 line, -1 line 0 comments Download
D include/utils/SkJSONCPP.h View 1 chunk +0 lines, -33 lines 0 comments Download
A + tools/SkJSONCPP.h View 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 18 (12 generated)
mtklein_C
4 years, 4 months ago (2016-07-26 19:07:36 UTC) #3
jcgregorio
lgtm
4 years, 4 months ago (2016-07-26 19:22:57 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2184483003/20001
4 years, 4 months ago (2016-07-26 19:30:44 UTC) #13
commit-bot: I haz the power
There were warnings when CQ was processing your CL: * CQ is not running the ...
4 years, 4 months ago (2016-07-26 19:30:45 UTC) #14
commit-bot: I haz the power
There were warnings when CQ was processing your CL: * CQ is not running the ...
4 years, 4 months ago (2016-07-26 19:30:59 UTC) #15
commit-bot: I haz the power
4 years, 4 months ago (2016-07-26 19:41:30 UTC) #18
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/1b51e0ec466026794f96e2c476f0c7f9db0f13dc

Powered by Google App Engine
This is Rietveld 408576698