Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(578)

Issue 2184473006: Convert editing/selection/5234383-[12].html to use w3c test harness (Closed)

Created:
4 years, 4 months ago by yosin_UTC9
Modified:
4 years, 4 months ago
Reviewers:
yoichio, Xiaocheng
CC:
blink-reviews, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert editing/selection/5234383-[12].html to use w3c test harness This patch converts "editing/selection/5234383-[12].html" to use w3c test harness to simplify test files and consolidate into "move_by_sentence_boundary.html" with additional test cases to improve test coverage. This patch is a preparation of getting rid of grammar checking feature. BUG=619452 TEST=n/a; this patch changes a test file Committed: https://crrev.com/afaa923d7e5acab54ae4470cdfeac225f272a8c0 Cr-Commit-Position: refs/heads/master@{#408057}

Patch Set 1 : 2016-07-27T13:42:56 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+101 lines, -126 lines) Patch
D third_party/WebKit/LayoutTests/editing/selection/5234383-1.html View 1 chunk +0 lines, -12 lines 0 comments Download
D third_party/WebKit/LayoutTests/editing/selection/5234383-2.html View 1 chunk +0 lines, -12 lines 0 comments Download
A third_party/WebKit/LayoutTests/editing/selection/modify_move/move_by_sentence_boundary.html View 1 chunk +101 lines, -0 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/editing/selection/5234383-1-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/editing/selection/5234383-1-expected.txt View 1 chunk +0 lines, -17 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/editing/selection/5234383-2-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/editing/selection/5234383-2-expected.txt View 1 chunk +0 lines, -17 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/editing/selection/5234383-1-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/editing/selection/5234383-1-expected.txt View 1 chunk +0 lines, -17 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/editing/selection/5234383-2-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/editing/selection/5234383-2-expected.txt View 1 chunk +0 lines, -17 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/editing/selection/5234383-1-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/editing/selection/5234383-1-expected.txt View 1 chunk +0 lines, -17 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/editing/selection/5234383-2-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/editing/selection/5234383-2-expected.txt View 1 chunk +0 lines, -17 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
yosin_UTC9
PTAL
4 years, 4 months ago (2016-07-27 05:10:09 UTC) #5
Xiaocheng
lgtm
4 years, 4 months ago (2016-07-27 06:13:30 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2184473006/1
4 years, 4 months ago (2016-07-27 06:13:58 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-07-27 06:17:33 UTC) #11
commit-bot: I haz the power
4 years, 4 months ago (2016-07-27 06:19:41 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/afaa923d7e5acab54ae4470cdfeac225f272a8c0
Cr-Commit-Position: refs/heads/master@{#408057}

Powered by Google App Engine
This is Rietveld 408576698