Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(401)

Issue 2184433002: [Mac/GN] In clean_up_old_versions.py, allow the Versions/ directory to not exist. (Closed)

Created:
4 years, 5 months ago by Robert Sesek
Modified:
4 years, 5 months ago
Reviewers:
Mark Mentovai
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Mac/GN] In clean_up_old_versions.py, allow the Versions/ directory to not exist. This can happen in a clean build if the clean_up_old_versions step runs before bundling, in a parallelized build. R=mark@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/342dc8a7ccd488ff10c258e00587bdac96fdcb15

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M chrome/tools/build/mac/clean_up_old_versions.py View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Robert Sesek
4 years, 5 months ago (2016-07-25 21:02:19 UTC) #1
Mark Mentovai
LGTM
4 years, 5 months ago (2016-07-25 21:03:09 UTC) #2
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/342dc8a7ccd488ff10c258e00587bdac96fdcb15 Cr-Commit-Position: refs/heads/master@{#407570}
4 years, 5 months ago (2016-07-25 21:06:19 UTC) #4
Robert Sesek
4 years, 5 months ago (2016-07-25 21:07:25 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
342dc8a7ccd488ff10c258e00587bdac96fdcb15.

Powered by Google App Engine
This is Rietveld 408576698