Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issue 2184393002: Implement a character stream for external one byte streams (Closed)

Created:
4 years, 4 months ago by jochen (gone - plz use gerrit)
Modified:
4 years, 4 months ago
Reviewers:
vogelheim, marja
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Implement a character stream for external one byte streams In contrast to the generic stream, this character stream works without accessing the heap, and can be used on a background thread. BUG=v8:5215 R=vogelheim@chromium.org,marja@chromium.org Committed: https://crrev.com/a661f611232bc49f37cff60c0e00112192e30d88 Cr-Commit-Position: refs/heads/master@{#38154}

Patch Set 1 #

Total comments: 1

Patch Set 2 : updates #

Unified diffs Side-by-side diffs Delta from patch set Stats (+113 lines, -19 lines) Patch
M src/parsing/parser.cc View 1 chunk +13 lines, -11 lines 0 comments Download
M src/parsing/scanner-character-streams.h View 3 chunks +24 lines, -2 lines 0 comments Download
M src/parsing/scanner-character-streams.cc View 1 3 chunks +49 lines, -6 lines 0 comments Download
M test/cctest/test-parsing.cc View 3 chunks +27 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
jochen (gone - plz use gerrit)
4 years, 4 months ago (2016-07-28 12:35:21 UTC) #1
vogelheim
lgtm https://codereview.chromium.org/2184393002/diff/1/src/parsing/scanner-character-streams.cc File src/parsing/scanner-character-streams.cc (right): https://codereview.chromium.org/2184393002/diff/1/src/parsing/scanner-character-streams.cc#newcode624 src/parsing/scanner-character-streams.cc:624: size_t length = kBufferSize; maybe: length = Min(kBufferSize, ...
4 years, 4 months ago (2016-07-28 15:03:13 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2184393002/20001
4 years, 4 months ago (2016-07-29 05:47:19 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-07-29 06:12:13 UTC) #10
commit-bot: I haz the power
4 years, 4 months ago (2016-07-29 06:13:49 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a661f611232bc49f37cff60c0e00112192e30d88
Cr-Commit-Position: refs/heads/master@{#38154}

Powered by Google App Engine
This is Rietveld 408576698