Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 2184363003: Revert of Flip the last Mac GYP bots to GN (the ASAN bots) (Closed)

Created:
4 years, 4 months ago by benwells
Modified:
4 years, 4 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@flip_mac_perf
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Flip the last Mac GYP bots to GN (the ASAN bots) (patchset #4 id:60001 of https://codereview.chromium.org/2168713003/ ) Reason for revert: The Mac ASAN bot is not compiling after this. Example stdio: https://build.chromium.org/p/chromium.memory/builders/Mac%20ASan%2064%20Builder/builds/40502/steps/compile/logs/stdio Original issue's description: > Flip the last Mac GYP bots to GN (the ASAN bots): > > This flips the remaining Mac builders to GN. A number of > browser_tests that use NaCl are failing under ASAN, so > we disable NaCl for now. > > This affects: > > - chromium.fyi > - ClangToTMacASan > - chromium.lkgr > - Mac ASAN Debug > - Mac ASAN Release Media > - Mac ASAN Release > - chromium.memory: > - Mac ASAN 64 Builder > - tryserver.chromium.mac: > - mac_chromium_asan_rel_ng > > TBR=rsesek@chromium.org, brettw@chromium.org, jyasskin@chromium.org > BUG=618468, 630322, 632059 > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.mac:mac_chromium_asan_rel_ng > > Committed: https://crrev.com/aff2a7f0744e477a728d0cacd467445df5b4d4e5 > Cr-Commit-Position: refs/heads/master@{#408345} TBR=rsesek@chromium.org,brettw@chromium.org,jyasskin@chromium.org,kinuko@chromium.org,dpranke@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=618468, 630322, 632059 Committed: https://crrev.com/788943c15aa5614f8b34e1933d4c1b367e4656a2 Cr-Commit-Position: refs/heads/master@{#408348}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -36 lines) Patch
M chrome/chrome_tests.gypi View 2 chunks +1 line, -1 line 0 comments Download
M chrome/test/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M tools/mb/mb_config.pyl View 8 chunks +23 lines, -34 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
benwells
Created Revert of Flip the last Mac GYP bots to GN (the ASAN bots)
4 years, 4 months ago (2016-07-28 06:44:56 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2184363003/1
4 years, 4 months ago (2016-07-28 06:46:13 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2184363003/1
4 years, 4 months ago (2016-07-28 06:55:13 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-07-28 07:01:11 UTC) #9
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/788943c15aa5614f8b34e1933d4c1b367e4656a2 Cr-Commit-Position: refs/heads/master@{#408348}
4 years, 4 months ago (2016-07-28 07:02:55 UTC) #11
Dirk Pranke
4 years, 4 months ago (2016-07-28 14:36:46 UTC) #12
Message was sent while issue was closed.
On 2016/07/28 07:02:55, commit-bot: I haz the power wrote:
> Patchset 1 (id:??) landed as
> https://crrev.com/788943c15aa5614f8b34e1933d4c1b367e4656a2
> Cr-Commit-Position: refs/heads/master@{#408348}

lgtm, thanks.

It looks like the Mac ASan 64 builder sets lsan=1. That has no effect on Mac in
GYP, but sets sanitize=leak in GN.
It probably shouldn't set lsan=1 at all.

Powered by Google App Engine
This is Rietveld 408576698