Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Unified Diff: third_party/WebKit/Source/platform/graphics/paint/PaintController.h

Issue 2184363002: Handle removed display items in under-invalidation checking in cached subsequences (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Make test expectations suitable for both debug and release+dcheck Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/graphics/paint/PaintController.h
diff --git a/third_party/WebKit/Source/platform/graphics/paint/PaintController.h b/third_party/WebKit/Source/platform/graphics/paint/PaintController.h
index 82eb5fb255ad4f0672f486e5ade00b580bcfc58d..1932051d611a5b163d4e55073e31ac7b50cf346a 100644
--- a/third_party/WebKit/Source/platform/graphics/paint/PaintController.h
+++ b/third_party/WebKit/Source/platform/graphics/paint/PaintController.h
@@ -175,7 +175,7 @@ protected:
}
private:
- friend class PaintControllerTest;
+ friend class PaintControllerTestBase;
friend class PaintControllerPaintTestBase;
void ensureNewDisplayItemListInitialCapacity()
@@ -212,7 +212,7 @@ private:
#if DCHECK_IS_ON()
// The following two methods are for checking under-invalidations
// (when RuntimeEnabledFeatures::slimmingPaintUnderInvalidationCheckingEnabled).
- void showUnderInvalidationError(const char* reason, const DisplayItem& newItem, const DisplayItem& oldItem) const;
+ void showUnderInvalidationError(const char* reason, const DisplayItem& newItem, const DisplayItem* oldItem) const;
void checkUnderInvalidation();
bool isCheckingUnderInvalidation() const { return m_underInvalidationCheckingEnd - m_underInvalidationCheckingBegin > 0; }
#endif
@@ -271,6 +271,10 @@ private:
// will check if the actual painting results are the same as the cached.
size_t m_underInvalidationCheckingBegin;
size_t m_underInvalidationCheckingEnd;
+ // Number of probable under-invalidations that have been skipped temporarily because the
+ // mismatching display items may be removed in the future because of no-op pairs or
+ // compositing folding.
+ int m_skippedProbableUnderInvalidationCount;
String m_underInvalidationMessagePrefix;
#endif

Powered by Google App Engine
This is Rietveld 408576698