third_party/WebKit/Source/web/RotationViewportAnchor.cpp - Issue 2184333002: Fix scroll anchoring during viewport resize.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/RotationViewportAnchor.cpp

Issue 2184333002: Fix scroll anchoring during viewport resize. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: add comment on m_drift Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/web/RotationViewportAnchor.cpp

diff --git a/third_party/WebKit/Source/web/RotationViewportAnchor.cpp b/third_party/WebKit/Source/web/RotationViewportAnchor.cpp

index fa65feb1fd9a9329271c26f7c2a5dba78e73b544..8449f57ef22bbad0da6908cd81ad64ea14423531 100644

--- a/third_party/WebKit/Source/web/RotationViewportAnchor.cpp

+++ b/third_party/WebKit/Source/web/RotationViewportAnchor.cpp

@@ -84,7 +84,8 @@ RotationViewportAnchor::RotationViewportAnchor(

VisualViewport& visualViewport,

const FloatSize& anchorInInnerViewCoords,

PageScaleConstraintsSet& pageScaleConstraintsSet)

- : ViewportAnchor(rootFrameView, visualViewport)

+ : m_rootFrameView(&rootFrameView)

+ , m_visualViewport(&visualViewport)

, m_anchorInInnerViewCoords(anchorInInnerViewCoords)

, m_pageScaleConstraintsSet(pageScaleConstraintsSet)

{