Issue 218433002: Temporary CHECK version 2 in IPC::Channel::Send() to help track down crash.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 218433002: Temporary CHECK version 2 in IPC::Channel::Send() to help track down crash. (Closed)

Created:
6 years, 8 months ago by viettrungluu

Modified:
6 years, 8 months ago

Reviewers:
cpu_(ooo_6.6-7.5), no sievers

CC:
chromium-reviews, darin-cc_chromium.org, jam

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Temporary CHECK version 2 in IPC::Channel::Send() to help track down crash. TBR=sievers@chromium.org, cpu@chromium.org BUG=357915 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=260399

Patch Set 1 #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -0 lines)			Patch
	M	ipc/ipc_channel_posix.cc	View		1 chunk	+2 lines, -0 lines	0 comments	Download
	M	ipc/ipc_channel_win.cc	View		1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

viettrungluu

Going to land this TBR (for kareng to merge to the branch) and then revert ...

6 years, 8 months ago (2014-03-29 22:36:12 UTC) #1

viettrungluu

Committed patchset #1 manually as r260399 (tree was closed).

6 years, 8 months ago (2014-03-29 22:38:38 UTC) #2

viettrungluu

6 years, 8 months ago (2014-03-29 22:42:46 UTC) #3

Message was sent while issue was closed.

On 2014/03/29 22:36:12, viettrungluu wrote:
> Going to land this TBR (for kareng to merge to the branch) and then revert
> shortly.

(Note that data() is equivalent to header(). Both just return Pickle::header_.)

Expand Messages | Collapse Messages