lib/src/validator/sdk_constraint.dart - Issue 2184303002: Make pub strong-mode clean.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: lib/src/validator/sdk_constraint.dart

Issue 2184303002: Make pub strong-mode clean. (Closed) Base URL: git@github.com:dart-lang/pub.git@master

Patch Set: Code review changes Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: lib/src/validator/sdk_constraint.dart

diff --git a/lib/src/validator/sdk_constraint.dart b/lib/src/validator/sdk_constraint.dart

index aa57baaa31f89e54aaf2751a61523e4e9485bd10..479a1ddbf703053cfd804f857b5c91b15ef38901 100644

--- a/lib/src/validator/sdk_constraint.dart

+++ b/lib/src/validator/sdk_constraint.dart

@@ -21,7 +21,8 @@ class SdkConstraintValidator extends Validator {

Future validate() async {

var dartConstraint = entrypoint.root.pubspec.dartSdkConstraint;

- if (dartConstraint.toString().startsWith("^")) {

+ if (dartConstraint is VersionRange &&

+ dartConstraint.toString().startsWith("^")) {

errors.add(

"^ version constraints aren't allowed for SDK constraints since "

"older versions of pub don't support them.\n"

« no previous file with comments | « lib/src/validator/dependency.dart ('k') | pubspec.yaml » ('j') | no next file with comments »