Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1103)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: lib/src/validator.dart

Issue 2184303002: Make pub strong-mode clean. (Closed) Base URL: git@github.com:dart-lang/pub.git@master
Patch Set: Code review changes Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « lib/src/utils.dart ('k') | lib/src/validator/dependency.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/src/validator.dart
diff --git a/lib/src/validator.dart b/lib/src/validator.dart
index 57b106ca9b6e4651b8b48b472ea19fc455c06231..b2b925defb9579ef9c071d921612173a4dae26e7 100644
--- a/lib/src/validator.dart
+++ b/lib/src/validator.dart
@@ -75,10 +75,8 @@ abstract class Validator {
return Future.wait(validators.map((validator) => validator.validate()))
.then((_) {
- var errors =
- flatten(validators.map((validator) => validator.errors));
- var warnings =
- flatten(validators.map((validator) => validator.warnings));
+ var errors = validators.expand((validator) => validator.errors);
+ var warnings = validators.expand((validator) => validator.warnings);
if (!errors.isEmpty) {
log.error("Missing requirements:");
« no previous file with comments | « lib/src/utils.dart ('k') | lib/src/validator/dependency.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698