lib/src/source/hosted.dart - Issue 2184303002: Make pub strong-mode clean.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: lib/src/source/hosted.dart

Issue 2184303002: Make pub strong-mode clean. (Closed) Base URL: git@github.com:dart-lang/pub.git@master

Patch Set: Code review changes Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: lib/src/source/hosted.dart

diff --git a/lib/src/source/hosted.dart b/lib/src/source/hosted.dart

index ddee56b71d30f3cded20631bbf8819a52e7c6643..5c2b76b6f8ac985e7774d2eeec613c577bb58905 100644

--- a/lib/src/source/hosted.dart

+++ b/lib/src/source/hosted.dart

@@ -212,8 +212,8 @@ class BoundHostedSource extends CachedSource {

Future<Pair<List<PackageId>, List<PackageId>>> repairCachedPackages() async {

if (!dirExists(systemCacheRoot)) return new Pair([], []);

- var successes = [];

- var failures = [];

+ var successes = <PackageId>[];

+ var failures = <PackageId>[];

for (var serverDir in listDir(systemCacheRoot)) {

var url = _directoryToUrl(p.basename(serverDir));

« no previous file with comments | « lib/src/source/git.dart ('k') | lib/src/system_cache.dart » ('j') | no next file with comments »