Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Unified Diff: lib/src/solver/version_solver.dart

Issue 2184303002: Make pub strong-mode clean. (Closed) Base URL: git@github.com:dart-lang/pub.git@master
Patch Set: Code review changes Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « lib/src/solver/solve_report.dart ('k') | lib/src/source.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/src/solver/version_solver.dart
diff --git a/lib/src/solver/version_solver.dart b/lib/src/solver/version_solver.dart
index 3c4553c26ae8ba0eaa96f0e4628376f652ca3430..2de19f4987ebf344f7e3b3db98707a337140da33 100644
--- a/lib/src/solver/version_solver.dart
+++ b/lib/src/solver/version_solver.dart
@@ -210,7 +210,7 @@ class SolverCache {
_versionCacheMisses++;
var source = _cache.source(package.source);
- var ids;
+ List<PackageId> ids;
try {
ids = await source.getVersions(package);
} catch (error, stackTrace) {
@@ -344,8 +344,8 @@ class BadSdkVersionException extends SolveFailure {
final String _message;
BadSdkVersionException(String package, String message)
- : super(package, null),
- _message = message;
+ : _message = message,
+ super(package, null);
}
/// Exception thrown when the [VersionConstraint] used to match a package is
« no previous file with comments | « lib/src/solver/solve_report.dart ('k') | lib/src/source.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698