lib/src/command/barback.dart - Issue 2184303002: Make pub strong-mode clean.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: lib/src/command/barback.dart

Issue 2184303002: Make pub strong-mode clean. (Closed) Base URL: git@github.com:dart-lang/pub.git@master

Patch Set: Code review changes Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: lib/src/command/barback.dart

diff --git a/lib/src/command/barback.dart b/lib/src/command/barback.dart

index 1ac2ea9a6240b0787c0aceffe5e312615a302b31..3e07773ca7d762a2d1158323a7d3b65905b0f02c 100644

--- a/lib/src/command/barback.dart

+++ b/lib/src/command/barback.dart

@@ -111,7 +111,7 @@ abstract class BarbackCommand extends PubCommand {

// Make sure the directories don't overlap.

var sources = sourceDirectories.toList();

- var overlapping = new Set();

+ var overlapping = new Set<String>();

for (var i = 0; i < sources.length; i++) {

for (var j = i + 1; j < sources.length; j++) {

if (path.isWithin(sources[i], sources[j]) ||

« no previous file with comments | « lib/src/command.dart ('k') | lib/src/command/build.dart » ('j') | no next file with comments »