Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(325)

Unified Diff: lib/src/barback/transformer_config.dart

Issue 2184303002: Make pub strong-mode clean. (Closed) Base URL: git@github.com:dart-lang/pub.git@master
Patch Set: Code review changes Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « lib/src/barback/pub_package_provider.dart ('k') | lib/src/barback/transformer_isolate.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/src/barback/transformer_config.dart
diff --git a/lib/src/barback/transformer_config.dart b/lib/src/barback/transformer_config.dart
index 67a8cba1451a13cbebb443fe494953132cbb10e9..896c7d63b311fe0e9106024a5d72f65a118177a6 100644
--- a/lib/src/barback/transformer_config.dart
+++ b/lib/src/barback/transformer_config.dart
@@ -79,7 +79,7 @@ class TransformerConfig {
configuration);
factory TransformerConfig(TransformerId id, YamlMap configurationNode) {
- parseField(key) {
+ Set<Glob> parseField(String key) {
if (!configurationNode.containsKey(key)) return null;
var fieldNode = configurationNode.nodes[key];
var field = fieldNode.value;
@@ -103,11 +103,10 @@ class TransformerConfig {
}));
}
- var includes = null;
- var excludes = null;
-
- var configuration;
- var span;
+ Set<Glob> includes;
+ Set<Glob> excludes;
+ Map configuration;
+ SourceSpan span;
if (configurationNode == null) {
configuration = {};
span = id.span;
« no previous file with comments | « lib/src/barback/pub_package_provider.dart ('k') | lib/src/barback/transformer_isolate.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698