Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(911)

Unified Diff: lib/src/barback/load_all_transformers.dart

Issue 2184303002: Make pub strong-mode clean. (Closed) Base URL: git@github.com:dart-lang/pub.git@master
Patch Set: Code review changes Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « lib/src/barback/foreign_transformer.dart ('k') | lib/src/barback/pub_package_provider.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/src/barback/load_all_transformers.dart
diff --git a/lib/src/barback/load_all_transformers.dart b/lib/src/barback/load_all_transformers.dart
index f21df9e2e20405527d922a94cc8747de59209775..3ebc1d70195395d7babae6dbd06fe69f510f2001 100644
--- a/lib/src/barback/load_all_transformers.dart
+++ b/lib/src/barback/load_all_transformers.dart
@@ -32,7 +32,7 @@ Future loadAllTransformers(AssetEnvironment environment,
// If we only need to load transformers for a specific set of entrypoints,
// remove any other transformers from [transformersNeededByTransformers].
- var necessaryTransformers;
+ Set<TransformerId> necessaryTransformers;
if (entrypoints != null) {
if (entrypoints.isEmpty) return;
@@ -126,10 +126,10 @@ List<Set<TransformerId>> _stageTransformers(
Map<TransformerId, Set<TransformerId>> transformerDependencies) {
// A map from transformer ids to the indices of the stages that those
// transformer ids should end up in. Populated by [stageNumberFor].
- var stageNumbers = {};
- var stages = [];
+ var stageNumbers = <TransformerId, int>{};
+ var stages = <Set<TransformerId>>[];
- stageNumberFor(id) {
+ stageNumberFor(TransformerId id) {
// Built-in transformers don't have to be loaded in stages, since they're
// run from pub's source. Return -1 so that the "next stage" is 0.
if (id.isBuiltInTransformer) return -1;
@@ -155,7 +155,7 @@ List<Set<TransformerId>> _stageTransformers(
/// transformer.
Map<TransformerId, Set<String>> _packagesThatUseTransformers(
PackageGraph graph) {
- var results = {};
+ var results = <TransformerId, Set<String>>{};
for (var package in graph.packages.values) {
for (var phase in package.pubspec.transformers) {
for (var config in phase) {
« no previous file with comments | « lib/src/barback/foreign_transformer.dart ('k') | lib/src/barback/pub_package_provider.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698