Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(922)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: lib/src/solver/solve_report.dart

Issue 2184303002: Make pub strong-mode clean. (Closed) Base URL: git@github.com:dart-lang/pub.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« lib/src/lock_file.dart ('K') | « lib/src/solver/backtracking_solver.dart ('k') | lib/src/solver/version_solver.dart » ('j') | test/descriptor/git.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/src/solver/solve_report.dart
diff --git a/lib/src/solver/solve_report.dart b/lib/src/solver/solve_report.dart
index 367d963a255a84a69ba7a965a08997ceeb2e61d0..20f40a9034bdc5fe60e655d78fa23f29a2046d3d 100644
--- a/lib/src/solver/solve_report.dart
+++ b/lib/src/solver/solve_report.dart
@@ -104,9 +104,9 @@ class SolveReport {
removed.removeAll(names);
if (removed.isNotEmpty) {
_output.writeln("These packages are no longer being depended on:");
- removed = removed.toList();
- removed.sort();
- removed.forEach((name) => _reportPackage(name, alwaysShow: true));
+ for (var name in ordered(removed)) {
+ _reportPackage(name, alwaysShow: true);
+ }
}
log.message(_output);
« lib/src/lock_file.dart ('K') | « lib/src/solver/backtracking_solver.dart ('k') | lib/src/solver/version_solver.dart » ('j') | test/descriptor/git.dart » ('J')

Powered by Google App Engine
This is Rietveld 408576698