Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(214)

Side by Side Diff: lib/src/solver/solve_report.dart

Issue 2184303002: Make pub strong-mode clean. (Closed) Base URL: git@github.com:dart-lang/pub.git@master
Patch Set: Code review changes Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « lib/src/solver/backtracking_solver.dart ('k') | lib/src/solver/version_solver.dart » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 import 'package:pub_semver/pub_semver.dart'; 5 import 'package:pub_semver/pub_semver.dart';
6 6
7 import '../lock_file.dart'; 7 import '../lock_file.dart';
8 import '../log.dart' as log; 8 import '../log.dart' as log;
9 import '../package.dart'; 9 import '../package.dart';
10 import '../source_registry.dart'; 10 import '../source_registry.dart';
(...skipping 86 matching lines...) Expand 10 before | Expand all | Expand 10 after
97 var names = _result.packages.map((id) => id.name).toList(); 97 var names = _result.packages.map((id) => id.name).toList();
98 names.remove(_root.name); 98 names.remove(_root.name);
99 names.sort(); 99 names.sort();
100 names.forEach(_reportPackage); 100 names.forEach(_reportPackage);
101 101
102 // Show any removed ones. 102 // Show any removed ones.
103 var removed = _previousLockFile.packages.keys.toSet(); 103 var removed = _previousLockFile.packages.keys.toSet();
104 removed.removeAll(names); 104 removed.removeAll(names);
105 if (removed.isNotEmpty) { 105 if (removed.isNotEmpty) {
106 _output.writeln("These packages are no longer being depended on:"); 106 _output.writeln("These packages are no longer being depended on:");
107 removed = removed.toList(); 107 for (var name in ordered(removed)) {
108 removed.sort(); 108 _reportPackage(name, alwaysShow: true);
109 removed.forEach((name) => _reportPackage(name, alwaysShow: true)); 109 }
110 } 110 }
111 111
112 log.message(_output); 112 log.message(_output);
113 } 113 }
114 114
115 /// Displays a warning about the overrides currently in effect. 115 /// Displays a warning about the overrides currently in effect.
116 void _reportOverrides() { 116 void _reportOverrides() {
117 _output.clear(); 117 _output.clear();
118 118
119 if (_result.overrides.isNotEmpty) { 119 if (_result.overrides.isNotEmpty) {
(...skipping 117 matching lines...) Expand 10 before | Expand all | Expand 10 after
237 /// Writes a terse description of [id] (not including its name) to the output. 237 /// Writes a terse description of [id] (not including its name) to the output.
238 void _writeId(PackageId id) { 238 void _writeId(PackageId id) {
239 _output.write(id.version); 239 _output.write(id.version);
240 240
241 if (id.source != _sources.defaultSource) { 241 if (id.source != _sources.defaultSource) {
242 var description = id.source.formatDescription(_root.dir, id.description); 242 var description = id.source.formatDescription(_root.dir, id.description);
243 _output.write(" from ${id.source} $description"); 243 _output.write(" from ${id.source} $description");
244 } 244 }
245 } 245 }
246 } 246 }
OLDNEW
« no previous file with comments | « lib/src/solver/backtracking_solver.dart ('k') | lib/src/solver/version_solver.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698