Make pub strong-mode clean.

lib/src/package.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 import 'dart:io';
 
 import 'package:barback/barback.dart';
 import 'package:path/path.dart' as p;
 import 'package:pub_semver/pub_semver.dart';
 
@@ skipping 42 matching lines @@
 
   /// The immediate dev dependencies this package specifies in its pubspec.
   List<PackageDep> get devDependencies => pubspec.devDependencies;
 
   /// The dependency overrides this package specifies in its pubspec.
   List<PackageDep> get dependencyOverrides => pubspec.dependencyOverrides;
 
   /// All immediate dependencies this package specifies.
   ///
   /// This includes regular, dev dependencies, and overrides.
-  Set<PackageDep> get immediateDependencies {
-    var deps = {};
+  List<PackageDep> get immediateDependencies {
+    var deps = <String, PackageDep>{};
 
     addToMap(dep) {
       deps[dep.name] = dep;
     }
 
     dependencies.forEach(addToMap);
     devDependencies.forEach(addToMap);
 
     // Make sure to add these last so they replace normal dependencies.
     dependencyOverrides.forEach(addToMap);
 
-    return deps.values.toSet();
+    return deps.values.toList();
   }
 
   /// Returns a list of asset ids for all Dart executables in this package's bin
   /// directory.
   List<AssetId> get executableIds {
     return ordered(listFiles(beneath: "bin", recursive: false))
         .where((executable) => p.extension(executable) == '.dart')
         .map((executable) {
       return new AssetId(
           name, p.toUri(p.relative(executable, from: dir)).toString());
@@ skipping 129 matching lines @@
       beneath = p.join(dir, beneath);
     }
 
     if (!dirExists(beneath)) return [];
 
     // This is used in some performance-sensitive paths and can list many, many
     // files. As such, it leans more havily towards optimization as opposed to
     // readability than most code in pub. In particular, it avoids using the
     // path package, since re-parsing a path is very expensive relative to
     // string operations.
-    var files;
+    Iterable<String> files;
     if (useGitIgnore && _inGitRepo) {
       // Later versions of git do not allow a path for ls-files that appears to
       // be outside of the repo, so make sure we give it a relative path.
       var relativeBeneath = p.relative(beneath, from: dir);
 
       // List all files that aren't gitignored, including those not checked in
       // to Git.
       files = git.runSync(
           ["ls-files", "--cached", "--others", "--exclude-standard",
            relativeBeneath],
@@ skipping 195 matching lines @@
   /// Creates an ID for a package with the given [name], [source], [version],
   /// and [description].
   ///
   /// Since an ID's description is an implementation detail of its source, this
   /// should generally not be called outside of [Source] subclasses.
   PackageId(String name, Source source, this.version, description)
       : super._(name, source, description);
 
   /// Creates an ID for a magic package (see [isMagic]).
   PackageId.magic(String name)
-      : super._magic(name),
-        version = Version.none;
+    : version = Version.none,
+      super._magic(name);
 
   /// Creates an ID for the given root package.
   PackageId.root(Package package)
       : version = package.version,
         super._(package.name, null, package.name);
 
   int get hashCode => super.hashCode ^ version.hashCode;
 
   bool operator ==(other) =>
       other is PackageId && samePackage(other) && other.version == version;
@@ skipping 12 matching lines @@
 
   /// Creates a reference to package with the given [name], [source],
   /// [constraint], and [description].
   ///
   /// Since an ID's description is an implementation detail of its source, this
   /// should generally not be called outside of [Source] subclasses.
   PackageDep(String name, Source source, this.constraint, description)
       : super._(name, source, description);
 
   PackageDep.magic(String name)
-      : super._magic(name),
-        constraint = Version.none;
+      : constraint = Version.none,
+        super._magic(name);
 
   String toString() {
     if (isRoot) return "$name $constraint (root)";
     if (isMagic) return name;
     return "$name $constraint from $source ($description)";
   }
 
   /// Whether [id] satisfies this dependency.
   ///
   /// Specifically, whether [id] refers to the same package as [this] *and*
   /// [constraint] allows `id.version`.
   bool allows(PackageId id) =>
       samePackage(id) && constraint.allows(id.version);
 
   int get hashCode => super.hashCode ^ constraint.hashCode;
 
   bool operator ==(other) =>
       other is PackageDep &&
       samePackage(other) &&
       other.constraint == constraint;
 }