Make pub strong-mode clean.

test/descriptor/git.dart

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 import 'dart:async';
 
 import 'package:path/path.dart' as path;
 import 'package:pub/src/git.dart' as git;
 import 'package:scheduled_test/scheduled_test.dart';
 import 'package:scheduled_test/descriptor.dart';
@@ skipping 24 matching lines @@
         ['add', '.'],
         ['commit', '-m', 'update']
       ]);
     });
   }, 'committing Git repo:\n${describe()}');
 
   /// Return a Future that completes to the commit in the git repository
   /// referred to by [ref] at the current point in the scheduled test run.
   ///
   /// [parent] defaults to [defaultRoot].
-  Future<String> revParse(String ref, [String parent]) => schedule(() {
-    return _runGit(['rev-parse', ref], parent).then((output) => output[0]);
-  }, 'parsing revision $ref for Git repo:\n${describe()}');
+  Future<String> revParse(String ref, [String parent]) {
+    return schedule/*<Future<String>>*/(() async {

[Bob Nystrom, 2016/07/29 00:31:22]

Shouldn't this just be <String>?

+      var output = await _runGit(['rev-parse', ref], parent);
+      return output[0];
+    }, 'parsing revision $ref for Git repo:\n${describe()}');
+  }
 
   /// Schedule a Git command to run in this repository.
   ///
   /// [parent] defaults to [defaultRoot].
   Future runGit(List<String> args, [String parent]) => schedule(() {
     return _runGit(args, parent);
   }, "running 'git ${args.join(' ')}' in Git repo:\n${describe()}");
 
-  Future _runGitCommands(String parent, List<List<String>> commands) =>
-      Future.forEach(commands, (command) => _runGit(command, parent));
+  Future _runGitCommands(String parent, List<List<String>> commands) async {
+    for (var command in commands) {
+      await _runGit(command, parent);
+    }
+  }
 
   Future<List<String>> _runGit(List<String> args, String parent) {
     // Explicitly specify the committer information. Git needs this to commit
     // and we don't want to rely on the buildbots having this already set up.
     var environment = {
       'GIT_AUTHOR_NAME': 'Pub Test',
       'GIT_AUTHOR_EMAIL': 'pub@dartlang.org',
       'GIT_COMMITTER_NAME': 'Pub Test',
       'GIT_COMMITTER_EMAIL': 'pub@dartlang.org'
     };
 
     if (parent == null) parent = defaultRoot;
     return git.run(args,
         workingDir: path.join(parent, name),
         environment: environment);
   }
 }