components/ntp_snippets/BUILD.gn - Issue 2184263005: Add a tab helper to record the last visit date for each bookmark.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/ntp_snippets/BUILD.gn

Issue 2184263005: Add a tab helper to record the last visit date for each bookmark. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Comments #2 Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/tab_helpers.cc ('K') | « components/ntp_snippets.gypi ('k') | components/ntp_snippets/bookmarks/DEPS » ('j') | components/ntp_snippets/bookmarks/bookmark_last_visit_utils.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/ntp_snippets/BUILD.gn

diff --git a/components/ntp_snippets/BUILD.gn b/components/ntp_snippets/BUILD.gn

index 9dd2e2d4fa2543d5adb93b0a7fed36c0caf0fffd..b8209d02fdd1fb59710b3421a56651083e734b68 100644

--- a/components/ntp_snippets/BUILD.gn

+++ b/components/ntp_snippets/BUILD.gn

@@ -12,6 +12,8 @@ if (is_android) {

# GYP version: components/ntp_snippets.gypi:ntp_snippets

static_library("ntp_snippets") {

sources = [

+ "bookmarks/bookmark_last_visit_utils.cc",

+ "bookmarks/bookmark_last_visit_utils.h",

"content_suggestion.cc",

"content_suggestion.h",

"content_suggestions_category.h",

@@ -58,6 +60,7 @@ static_library("ntp_snippets") {

]

deps = [

+ "//components/bookmarks/browser",

"//components/data_use_measurement/core",

"//components/image_fetcher",

"//components/metrics",