third_party/WebKit/Source/core/loader/DocumentThreadableLoader.h - Issue 2184263003: Move RawResourceClient to Oilpan heap

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/loader/DocumentThreadableLoader.h

Issue 2184263003: Move RawResourceClient to Oilpan heap (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@onheap-threadable-loader

Patch Set: rebase Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/core/loader/DocumentThreadableLoader.h

diff --git a/third_party/WebKit/Source/core/loader/DocumentThreadableLoader.h b/third_party/WebKit/Source/core/loader/DocumentThreadableLoader.h

index 79e8336d7cd4c0cb5dbb45cb5293dd69c5222cb4..9339551eddeb4911892bbd9024163bc9d2d8695c 100644

--- a/third_party/WebKit/Source/core/loader/DocumentThreadableLoader.h

+++ b/third_party/WebKit/Source/core/loader/DocumentThreadableLoader.h

@@ -54,7 +54,7 @@ class ResourceRequest;

class SecurityOrigin;

class ThreadableLoaderClient;

-class CORE_EXPORT DocumentThreadableLoader final : public ThreadableLoader, private ResourceOwner<RawResource> {

+class CORE_EXPORT DocumentThreadableLoader final : public ThreadableLoader, public ResourceOwner<RawResource> {

Nate Chapin 2016/08/03 19:37:01 I don't immediately see why private->public is nec

yhirano 2016/08/09 07:16:44 I thought it necessary, but it's apparently not. R

USING_GARBAGE_COLLECTED_MIXIN(DocumentThreadableLoader);

public:

static void loadResourceSynchronously(Document&, const ResourceRequest&, ThreadableLoaderClient&, const ThreadableLoaderOptions&, const ResourceLoaderOptions&);

« third_party/WebKit/Source/core/fetch/RawResource.h ('K') | « third_party/WebKit/Source/core/loader/DocumentLoader.cpp ('k') | no next file » | no next file with comments »