Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Side by Side Diff: third_party/WebKit/Source/core/fetch/RawResource.h

Issue 2184263003: Move RawResourceClient to Oilpan heap (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@onheap-threadable-loader
Patch Set: rebase Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 Copyright (C) 1998 Lars Knoll (knoll@mpi-hd.mpg.de) 2 Copyright (C) 1998 Lars Knoll (knoll@mpi-hd.mpg.de)
3 Copyright (C) 2001 Dirk Mueller <mueller@kde.org> 3 Copyright (C) 2001 Dirk Mueller <mueller@kde.org>
4 Copyright (C) 2006 Samuel Weinig (sam.weinig@gmail.com) 4 Copyright (C) 2006 Samuel Weinig (sam.weinig@gmail.com)
5 Copyright (C) 2004, 2005, 2006, 2007 Apple Inc. All rights reserved. 5 Copyright (C) 2004, 2005, 2006, 2007 Apple Inc. All rights reserved.
6 6
7 This library is free software; you can redistribute it and/or 7 This library is free software; you can redistribute it and/or
8 modify it under the terms of the GNU Library General Public 8 modify it under the terms of the GNU Library General Public
9 License as published by the Free Software Foundation; either 9 License as published by the Free Software Foundation; either
10 version 2 of the License, or (at your option) any later version. 10 version 2 of the License, or (at your option) any later version.
(...skipping 84 matching lines...) Expand 10 before | Expand all | Expand 10 after
95 Resource::Type type = resource.getType(); 95 Resource::Type type = resource.getType();
96 return type == Resource::MainResource || type == Resource::Raw || type == Re source::TextTrack || type == Resource::Media || type == Resource::Manifest || ty pe == Resource::ImportResource; 96 return type == Resource::MainResource || type == Resource::Raw || type == Re source::TextTrack || type == Resource::Media || type == Resource::Manifest || ty pe == Resource::ImportResource;
97 } 97 }
98 #endif 98 #endif
99 inline RawResource* toRawResource(Resource* resource) 99 inline RawResource* toRawResource(Resource* resource)
100 { 100 {
101 ASSERT_WITH_SECURITY_IMPLICATION(!resource || isRawResource(*resource)); 101 ASSERT_WITH_SECURITY_IMPLICATION(!resource || isRawResource(*resource));
102 return static_cast<RawResource*>(resource); 102 return static_cast<RawResource*>(resource);
103 } 103 }
104 104
105 class CORE_EXPORT RawResourceClient : public ResourceClient { 105 class CORE_EXPORT RawResourceClient : public GarbageCollectedMixin, public Resou rceClient {
Nate Chapin 2016/08/03 19:37:01 Nit: I've usually seen GarbageCollecedMixin as the
yhirano 2016/08/09 07:16:44 I get an error when I specify GarbageCollecteMixin
106 public: 106 public:
107 RawResourceClient()
108 : m_weakFactory(this) { }
109 WeakPtr<RawResourceClient> createWeakPtr() { return m_weakFactory.createWeak Ptr(); }
110 ~RawResourceClient() override {}
111 static bool isExpectedType(ResourceClient* client) { return client->getResou rceClientType() == RawResourceType; } 107 static bool isExpectedType(ResourceClient* client) { return client->getResou rceClientType() == RawResourceType; }
112 ResourceClientType getResourceClientType() const final { return RawResourceT ype; } 108 ResourceClientType getResourceClientType() const final { return RawResourceT ype; }
113 109
114 virtual void dataSent(Resource*, unsigned long long /* bytesSent */, unsigne d long long /* totalBytesToBeSent */) { } 110 virtual void dataSent(Resource*, unsigned long long /* bytesSent */, unsigne d long long /* totalBytesToBeSent */) { }
115 virtual void responseReceived(Resource*, const ResourceResponse&, std::uniqu e_ptr<WebDataConsumerHandle>) { } 111 virtual void responseReceived(Resource*, const ResourceResponse&, std::uniqu e_ptr<WebDataConsumerHandle>) { }
116 virtual void setSerializedCachedMetadata(Resource*, const char*, size_t) { } 112 virtual void setSerializedCachedMetadata(Resource*, const char*, size_t) { }
117 virtual void dataReceived(Resource*, const char* /* data */, size_t /* lengt h */) { } 113 virtual void dataReceived(Resource*, const char* /* data */, size_t /* lengt h */) { }
118 virtual void redirectReceived(Resource*, ResourceRequest&, const ResourceRes ponse&) { } 114 virtual void redirectReceived(Resource*, ResourceRequest&, const ResourceRes ponse&) { }
119 virtual void redirectBlocked() {} 115 virtual void redirectBlocked() {}
120 virtual void dataDownloaded(Resource*, int) { } 116 virtual void dataDownloaded(Resource*, int) { }
121 virtual void didReceiveResourceTiming(Resource*, const ResourceTimingInfo&) { } 117 virtual void didReceiveResourceTiming(Resource*, const ResourceTimingInfo&) { }
122 118
123 private: 119 DEFINE_INLINE_VIRTUAL_TRACE() {}
124 WeakPtrFactory<RawResourceClient> m_weakFactory;
125 }; 120 };
126 121
127 } // namespace blink 122 } // namespace blink
128 123
129 #endif // RawResource_h 124 #endif // RawResource_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698