Reset HTTP/2 stream on line-folded response headers.

Reset HTTP/2 stream on line-folded response headers.

Also add unittests for HeaderCoalescer.

BUG=524041, 621487
Committed: https://crrev.com/204a6d0ef40d2e1fb16b7a39bb61d63c0da80c28
Cr-Commit-Position: refs/heads/master@{#408962}

[Bence, 2016-07-27 19:21:46]

The CQ bit was checked by bnc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-27 19:22:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-27 20:18:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-27 20:18:55]

Dry run: This issue passed the CQ dry run.

[Bence, 2016-07-27 23:24:06]

bnc@chromium.org changed reviewers:
+ rch@chromium.org

[Bence, 2016-07-27 23:24:06]

Ryan: PTAL.  Thank you.

[Ryan Hamilton, 2016-07-27 23:36:58]

lgtm, but one question

https://codereview.chromium.org/2184253002/diff/1/net/spdy/header_coalescer.cc
File net/spdy/header_coalescer.cc (right):

https://codereview.chromium.org/2184253002/diff/1/net/spdy/header_coalescer.c...
net/spdy/header_coalescer.cc:42: // Line folding is forbidden by RFC 7230
Section 3.2.4.
Can we simply check for \r\n? It seems like that's an illegal sequence in
HTTP/1.1 since that is the end of line delimiter?

[Bence, 2016-08-01 13:40:05]

The CQ bit was checked by bnc@chromium.org

[Bence, 2016-08-01 13:40:06]

The patchset sent to the CQ was uploaded after l-g-t-m from rch@chromium.org
Link to the patchset: https://codereview.chromium.org/2184253002/#ps40001
(title: "Re: #7.")

[commit-bot: I haz the power, 2016-08-01 13:40:22]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Bence, 2016-08-01 14:06:17]

Thank you.

https://codereview.chromium.org/2184253002/diff/1/net/spdy/header_coalescer.cc
File net/spdy/header_coalescer.cc (right):

https://codereview.chromium.org/2184253002/diff/1/net/spdy/header_coalescer.c...
net/spdy/header_coalescer.cc:42: // Line folding is forbidden by RFC 7230
Section 3.2.4.
On 2016/07/27 23:36:58, Ryan Hamilton wrote:
> Can we simply check for \r\n? It seems like that's an illegal sequence in
> HTTP/1.1 since that is the end of line delimiter?

I agree.  Done.

[commit-bot: I haz the power, 2016-08-01 14:34:46]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-08-01 14:36:32]

Description was changed from

==========
Reset HTTP/2 stream on line-folded response headers.

Also add unittests for HeaderCoalescer.

BUG=524041, 621487
==========

to

==========
Reset HTTP/2 stream on line-folded response headers.

Also add unittests for HeaderCoalescer.

BUG=524041, 621487

Committed: https://crrev.com/204a6d0ef40d2e1fb16b7a39bb61d63c0da80c28
Cr-Commit-Position: refs/heads/master@{#408962}
==========

[commit-bot: I haz the power, 2016-08-01 14:36:33]

Patchset 3 (id:??) landed as
https://crrev.com/204a6d0ef40d2e1fb16b7a39bb61d63c0da80c28
Cr-Commit-Position: refs/heads/master@{#408962}