Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1072)

Issue 2184223004: Move DOMConvenienceAPI to stable. (Closed)

Created:
4 years, 4 months ago by sof
Modified:
4 years, 4 months ago
Reviewers:
tkent, ojan
CC:
blink-reviews, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move DOMConvenienceAPI to stable. Move ChildNode.{before,after,replaceWith}() + ParentNode.{prepend,append}() to stable. R= BUG=255482 Committed: https://crrev.com/3caee2bd4c6b161211450d70f5fd7aab04260c0a Cr-Commit-Position: refs/heads/master@{#408582}

Patch Set 1 #

Patch Set 2 : sync expecteds #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -1 line) Patch
M third_party/WebKit/LayoutTests/virtual/stable/webexposed/element-instance-property-listing-expected.txt View 1 6 chunks +10 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-expected.txt View 1 7 chunks +15 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 18 (12 generated)
ojan
lgtm once you get the third LGTM on the intent to ship thread.
4 years, 4 months ago (2016-07-28 16:10:46 UTC) #10
sof
thanks ojan@, over to tkent@ for final approval.
4 years, 4 months ago (2016-07-29 05:33:33 UTC) #12
tkent
lgtm
4 years, 4 months ago (2016-07-29 05:34:41 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2184223004/20001
4 years, 4 months ago (2016-07-29 05:41:49 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-07-29 05:45:05 UTC) #16
commit-bot: I haz the power
4 years, 4 months ago (2016-07-29 05:47:15 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/3caee2bd4c6b161211450d70f5fd7aab04260c0a
Cr-Commit-Position: refs/heads/master@{#408582}

Powered by Google App Engine
This is Rietveld 408576698