Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Issue 2184223002: Makes DockedWindowLayoutManager::UpdateDockBounds() handle null shelf_ (Closed)

Created:
4 years, 4 months ago by sky
Modified:
4 years, 4 months ago
Reviewers:
James Cook
CC:
chromium-reviews, kalyank, sadrul
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Makes DockedWindowLayoutManager::UpdateDockBounds() handle null shelf_ This is needed for mash as we asynchronously set the shelf, which is not expected. The async creation is temporary while we support sysui. Once sysui goes away this code shouldn't be needed. BUG=632099 TEST=none R=jamescook@chromium.org Committed: https://crrev.com/ba1fdb52586c4c5eaeb182444552bc6f3d6b4711 Cr-Commit-Position: refs/heads/master@{#408219}

Patch Set 1 #

Patch Set 2 : better comment #

Patch Set 3 : merge and bug #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -4 lines) Patch
M ash/common/wm/dock/docked_window_layout_manager.cc View 1 2 1 chunk +10 lines, -4 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
sky
I updated the description to reflect this is temporary and added a pointer to the ...
4 years, 4 months ago (2016-07-27 19:19:15 UTC) #5
James Cook
LGTM
4 years, 4 months ago (2016-07-27 19:43:53 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2184223002/40001
4 years, 4 months ago (2016-07-27 19:45:22 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 4 months ago (2016-07-27 19:55:36 UTC) #11
commit-bot: I haz the power
4 years, 4 months ago (2016-07-27 19:58:36 UTC) #13
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/ba1fdb52586c4c5eaeb182444552bc6f3d6b4711
Cr-Commit-Position: refs/heads/master@{#408219}

Powered by Google App Engine
This is Rietveld 408576698