Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2184203004:
🎫 Register policy providers only once (Closed)
DescriptionRegister policy providers only once
They were being re-registered for each new activity and never
unregistered.
BUG=632042
Committed: https://crrev.com/86c77fcc18da9e983c9d0b8f80de71809d4daac0
Cr-Commit-Position: refs/heads/master@{#410157}
Patch Set 1 #
Total comments: 2
Patch Set 2 : move to onStartNativeInitialization #Patch Set 3 : revert accidentally added build file. #Messages
Total messages: 23 (13 generated)
agrieve@chromium.org changed reviewers: + dfalcantara@chromium.org, wnwen@chromium.org
The CQ bit was checked by agrieve@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Swapping myself out for Yusuf; he knows initialization better than I do.
dfalcantara@chromium.org changed reviewers: + yusufo@google.com
Really, really swapping.
yusufo@chromium.org changed reviewers: + yusufo@chromium.org
https://codereview.chromium.org/2184203004/diff/1/chrome/android/java/src/org... File chrome/android/java/src/org/chromium/chrome/browser/init/ChromeBrowserInitializer.java (right): https://codereview.chromium.org/2184203004/diff/1/chrome/android/java/src/org... chrome/android/java/src/org/chromium/chrome/browser/init/ChromeBrowserInitializer.java:207: mApplication.registerPolicyProviders(CombinedPolicyProvider.get()); maybe onStartNativeInitialization might be a better place for this maybe? You basically are moving it from post native load to before all java initialization right now. and do we unregister it somewhere now?
https://codereview.chromium.org/2184203004/diff/1/chrome/android/java/src/org... File chrome/android/java/src/org/chromium/chrome/browser/init/ChromeBrowserInitializer.java (right): https://codereview.chromium.org/2184203004/diff/1/chrome/android/java/src/org... chrome/android/java/src/org/chromium/chrome/browser/init/ChromeBrowserInitializer.java:207: mApplication.registerPolicyProviders(CombinedPolicyProvider.get()); On 2016/07/27 22:54:49, Yusuf wrote: > maybe onStartNativeInitialization might be a better place for this maybe? You > basically are moving it from post native load to before all java initialization > right now. > > and do we unregister it somewhere now? I didn't see it using any JNI, but also don't have a good grasp of where to put it that is friendliest to start-up. Moved it to onStartNativeInitialization. We unregister Policy listeners when activities are destroyed, but we never unregister policy providers. The code here: https://codereview.chromium.org/2188723003/# Was clearing them when the last activity is destroyed... except it wasn't.
lgtm
The CQ bit was checked by agrieve@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm
The CQ bit was checked by agrieve@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== Register policy providers only once They were being re-registered for each new activity and never unregistered. BUG=632042 ========== to ========== Register policy providers only once They were being re-registered for each new activity and never unregistered. BUG=632042 Committed: https://crrev.com/86c77fcc18da9e983c9d0b8f80de71809d4daac0 Cr-Commit-Position: refs/heads/master@{#410157} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/86c77fcc18da9e983c9d0b8f80de71809d4daac0 Cr-Commit-Position: refs/heads/master@{#410157} |
