Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(345)

Issue 2184163002: Register delete time period pref for CBD on iOS (Closed)

Created:
4 years, 4 months ago by ioanap
Modified:
4 years, 4 months ago
Reviewers:
msramek, sdefresne
CC:
chromium-reviews, sdefresne+watch_chromium.org, melandory
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Register delete time period pref for Clear Browsing Data on iOS This will be set via a time selector in the Clear Browsing Data UI on iOS. BUG=620318 Committed: https://crrev.com/9df0d1577a70b4151471b59211443f7c778b6559 Cr-Commit-Position: refs/heads/master@{#408373}

Patch Set 1 #

Patch Set 2 : Fixed layout in ios_chrome.gyp #

Patch Set 3 : Make pref syncable #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M ios/chrome/browser/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ios/chrome/browser/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M ios/chrome/browser/prefs/browser_prefs.mm View 1 2 2 chunks +4 lines, -0 lines 0 comments Download
M ios/chrome/ios_chrome.gyp View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 17 (10 generated)
ioanap
Please take a look! msramek@: for DEPS on components/browsing_data/core Thank you, Ioana
4 years, 4 months ago (2016-07-28 10:01:33 UTC) #7
sdefresne
4 years, 4 months ago (2016-07-28 10:09:28 UTC) #9
sdefresne
lgtm Sorry clicked wrong button first time.
4 years, 4 months ago (2016-07-28 10:09:41 UTC) #10
msramek
LGTM
4 years, 4 months ago (2016-07-28 10:33:43 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2184163002/40001
4 years, 4 months ago (2016-07-28 10:42:05 UTC) #13
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 4 months ago (2016-07-28 11:32:31 UTC) #15
commit-bot: I haz the power
4 years, 4 months ago (2016-07-28 11:34:28 UTC) #17
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/9df0d1577a70b4151471b59211443f7c778b6559
Cr-Commit-Position: refs/heads/master@{#408373}

Powered by Google App Engine
This is Rietveld 408576698