Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(274)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2184143002: Rename textual includes as *.inc. (Closed)

Created:
4 years, 4 months ago by dogben
Modified:
4 years, 4 months ago
Reviewers:
caryclark
CC:
reviews_skia.org, mtklein
Base URL:
https://skia.googlesource.com/skia@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Rename textual includes as *.inc. This makes it easier to distinguish source files that can stand on their own vs files meant to be #included into other source files. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2184143002 Committed: https://skia.googlesource.com/skia/+/cb571e11480e929a1fa18c47ffa2c0ee22f87afb

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -17763 lines) Patch
M gyp/animator.gyp View 1 chunk +2 lines, -2 lines 0 comments Download
M public.bzl View 1 chunk +1 line, -1 line 0 comments Download
M src/animator/SkBuildCondensedInfo.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
D src/animator/SkCondensedDebug.cpp View 1 chunk +0 lines, -1387 lines 0 comments Download
A + src/animator/SkCondensedDebug.inc View 0 chunks +-1 lines, --1 lines 0 comments Download
D src/animator/SkCondensedRelease.cpp View 1 chunk +0 lines, -1365 lines 0 comments Download
A + src/animator/SkCondensedRelease.inc View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/animator/SkGetCondensedInfo.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
D src/utils/SkWhitelistChecksums.cpp View 1 chunk +0 lines, -50 lines 0 comments Download
A + src/utils/SkWhitelistChecksums.inc View 1 chunk +1 line, -1 line 0 comments Download
M src/utils/SkWhitelistTypefaces.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/sk_tool_utils_font.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
D tools/test_font_index.cpp View 1 chunk +0 lines, -99 lines 0 comments Download
A + tools/test_font_index.inc View 0 chunks +-1 lines, --1 lines 0 comments Download
D tools/test_font_monospace.cpp View 1 chunk +0 lines, -4847 lines 0 comments Download
A + tools/test_font_monospace.inc View 0 chunks +-1 lines, --1 lines 0 comments Download
D tools/test_font_sans_serif.cpp View 1 chunk +0 lines, -4857 lines 0 comments Download
A + tools/test_font_sans_serif.inc View 0 chunks +-1 lines, --1 lines 0 comments Download
D tools/test_font_serif.cpp View 1 chunk +0 lines, -5149 lines 0 comments Download
A + tools/test_font_serif.inc View 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
dogben
4 years, 4 months ago (2016-07-27 16:25:49 UTC) #7
caryclark
lgtm
4 years, 4 months ago (2016-07-27 16:29:30 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2184143002/1
4 years, 4 months ago (2016-07-27 17:23:59 UTC) #10
commit-bot: I haz the power
4 years, 4 months ago (2016-07-27 18:12:15 UTC) #12
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/cb571e11480e929a1fa18c47ffa2c0ee22f87afb

Powered by Google App Engine
This is Rietveld 408576698