chrome/test/data/webui/util_test.html - Issue 2184123003: Use event path to detect if anchor has been clicked in WebUIs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/data/webui/util_test.html

Issue 2184123003: Use event path to detect if anchor has been clicked in WebUIs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@close_dialog_on_query

Patch Set: add test to util_test.html Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/test/data/webui/md_history/history_list_test.js ('K') | « chrome/test/data/webui/md_history/history_list_test.js ('k') | ui/webui/resources/js/util.js » ('j') | ui/webui/resources/js/util.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/test/data/webui/util_test.html

diff --git a/chrome/test/data/webui/util_test.html b/chrome/test/data/webui/util_test.html

index 0c8c4eabf43456b81243084ea5de692a6e0c649b..7ad4a2872b3eb1b639df7f44ebb74772de676c52 100644

--- a/chrome/test/data/webui/util_test.html

+++ b/chrome/test/data/webui/util_test.html

@@ -1,6 +1,8 @@

<!DOCTYPE html>

<html>

<body>

+<a id="file" href="file:///path/to/file">File</a>

+<a id="chrome" href="about:chrome">Chrome</a>

function testQuoteString() {

@@ -20,6 +22,18 @@ function testQuoteString() {

assertEquals(null, match);

}

+function testClickHandler() {

+ var lastArgs = null;

+ chrome.send = function(message, args) {

Dan Beam 2016/08/02 06:02:43 also a bummer

Dan Beam 2016/08/02 06:02:43 at least replace this, IMO, after you're done

calamity 2016/08/08 05:06:43 Done.

+ assertEquals('navigateToUrl', message);

+ lastArgs = args;

Dan Beam 2016/08/02 06:02:43 clickArgs or clickParams, IMO

calamity 2016/08/08 05:06:43 Done.

+ }

Dan Beam 2016/08/02 06:02:43 };

calamity 2016/08/08 05:06:43 Done.

+ $('file').click();

+ assertEquals('file:///path/to/file', lastArgs[0]);

+ $('chrome').click();

+ assertEquals('about:chrome', lastArgs[0]);

</script>

</body>

</html>