Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2184063002:
[stubs] Cleanup CodeFactory. (Closed)
|
Created:
4 years, 4 months ago by Igor Sheludko Modified:
4 years, 4 months ago Reviewers:
Jakob Kummerow CC:
v8-reviews_googlegroups.com Base URL:
https://chromium.googlesource.com/v8/v8.git@master Target Ref:
refs/pending/heads/master Project:
v8 Visibility:
Public. |
Description[stubs] Cleanup CodeFactory.
Inline XxxIC::initialize_stub_in_optimized_code() methods to CodeFactory and use stub's call interface descriptor instead of hard-coded one.
BUG=v8:5236
Committed: https://crrev.com/1ca3d09939da6e0e996d36ae2c1e465e1d7cf055
Cr-Commit-Position: refs/heads/master@{#38093}
Patch Set 1 #
Total comments: 6
Patch Set 2 : Fix #
Dependent Patchsets: Messages
Total messages: 24 (18 generated)
Patchset #1 (id:1) has been deleted
Description was changed from ========== [stubs] Cleanup CodeFactory. BUG=v8:5236 ========== to ========== [stubs] Cleanup CodeFactory. Inline XxxIC::initialize_stub_in_optimized_code() methods to CodeFactory. BUG=v8:5236 ==========
Description was changed from ========== [stubs] Cleanup CodeFactory. Inline XxxIC::initialize_stub_in_optimized_code() methods to CodeFactory. BUG=v8:5236 ========== to ========== [stubs] Cleanup CodeFactory. Inline XxxIC::initialize_stub_in_optimized_code() methods to CodeFactory and use stub's call interface descriptor instead of hard-coding it. BUG=v8:5236 ==========
The CQ bit was checked by ishell@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: v8_android_arm_compile_rel on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_android_arm_compile_rel/...) v8_linux64_asan_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel_ng/buil...) v8_linux64_avx2_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng/buil...) v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng/build...) v8_linux64_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel_ng/builds/9776) v8_linux_arm64_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel_ng/build...) v8_linux_arm_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel_ng/builds/...) v8_linux_dbg_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg_ng/builds/9762) v8_linux_gcc_compile_rel on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_gcc_compile_rel/bu...) v8_linux_mips64el_compile_rel on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mips64el_compile_r...) v8_linux_mipsel_compile_rel on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mipsel_compile_rel...) v8_linux_nodcheck_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_nodcheck_rel_ng/bu...) v8_linux_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_rel_ng/builds/9722) v8_mac_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel_ng/builds/5748) v8_presubmit on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/20321)
Patchset #1 (id:20001) has been deleted
The CQ bit was checked by ishell@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
ishell@chromium.org changed reviewers: + jkummerow@chromium.org
PTAL
Description was changed from ========== [stubs] Cleanup CodeFactory. Inline XxxIC::initialize_stub_in_optimized_code() methods to CodeFactory and use stub's call interface descriptor instead of hard-coding it. BUG=v8:5236 ========== to ========== [stubs] Cleanup CodeFactory. Inline XxxIC::initialize_stub_in_optimized_code() methods to CodeFactory and use stub's call interface descriptor instead of hard-coded one. BUG=v8:5236 ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
LGTM. What's with the cases that haven't been converted? https://codereview.chromium.org/2184063002/diff/40001/src/code-factory.cc File src/code-factory.cc (right): https://codereview.chromium.org/2184063002/diff/40001/src/code-factory.cc#new... src/code-factory.cc:67: return Callable(stub.GetCode(), LoadDescriptor(isolate)); why not here? https://codereview.chromium.org/2184063002/diff/40001/src/code-factory.cc#new... src/code-factory.cc:239: return Callable(stub.GetCode(), stub.GetCallInterfaceDescriptor()); why not? https://codereview.chromium.org/2184063002/diff/40001/src/code-factory.cc#new... src/code-factory.cc:438: return Callable(stub.GetCode(), stub.GetCallInterfaceDescriptor()); why not?
https://codereview.chromium.org/2184063002/diff/40001/src/code-factory.cc File src/code-factory.cc (right): https://codereview.chromium.org/2184063002/diff/40001/src/code-factory.cc#new... src/code-factory.cc:67: return Callable(stub.GetCode(), LoadDescriptor(isolate)); On 2016/07/27 11:29:34, Jakob wrote: > why not here? Oops. Done. https://codereview.chromium.org/2184063002/diff/40001/src/code-factory.cc#new... src/code-factory.cc:239: return Callable(stub.GetCode(), stub.GetCallInterfaceDescriptor()); On 2016/07/27 11:29:34, Jakob wrote: > why not? This one uses ON_STACK_CALL_INTERFACE_DESCRIPTOR macro to define a descriptor and there's no a separate descriptor class for RegExpExecStub. Let's leave it as is for now. https://codereview.chromium.org/2184063002/diff/40001/src/code-factory.cc#new... src/code-factory.cc:438: return Callable(stub.GetCode(), stub.GetCallInterfaceDescriptor()); On 2016/07/27 11:29:34, Jakob wrote: > why not? Same here.
The CQ bit was checked by ishell@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from jkummerow@chromium.org Link to the patchset: https://codereview.chromium.org/2184063002/#ps60001 (title: "Fix")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== [stubs] Cleanup CodeFactory. Inline XxxIC::initialize_stub_in_optimized_code() methods to CodeFactory and use stub's call interface descriptor instead of hard-coded one. BUG=v8:5236 ========== to ========== [stubs] Cleanup CodeFactory. Inline XxxIC::initialize_stub_in_optimized_code() methods to CodeFactory and use stub's call interface descriptor instead of hard-coded one. BUG=v8:5236 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:60001)
Message was sent while issue was closed.
Description was changed from ========== [stubs] Cleanup CodeFactory. Inline XxxIC::initialize_stub_in_optimized_code() methods to CodeFactory and use stub's call interface descriptor instead of hard-coded one. BUG=v8:5236 ========== to ========== [stubs] Cleanup CodeFactory. Inline XxxIC::initialize_stub_in_optimized_code() methods to CodeFactory and use stub's call interface descriptor instead of hard-coded one. BUG=v8:5236 Committed: https://crrev.com/1ca3d09939da6e0e996d36ae2c1e465e1d7cf055 Cr-Commit-Position: refs/heads/master@{#38093} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/1ca3d09939da6e0e996d36ae2c1e465e1d7cf055 Cr-Commit-Position: refs/heads/master@{#38093} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
