Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(717)

Unified Diff: content/browser/frame_host/cross_process_frame_connector.h

Issue 2184033003: Refactor browser process coordinate transformation methods (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Removed problematic DCHECK Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/surfaces/surface_hittest.cc ('k') | content/browser/frame_host/cross_process_frame_connector.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/frame_host/cross_process_frame_connector.h
diff --git a/content/browser/frame_host/cross_process_frame_connector.h b/content/browser/frame_host/cross_process_frame_connector.h
index 0af9c831f53c24cf17367b9515a7032308db4e97..5111607f3b1e844d7cd56b44145841e6f5775e0c 100644
--- a/content/browser/frame_host/cross_process_frame_connector.h
+++ b/content/browser/frame_host/cross_process_frame_connector.h
@@ -97,7 +97,20 @@ class CONTENT_EXPORT CrossProcessFrameConnector {
void GetScreenInfo(blink::WebScreenInfo* results);
void UpdateCursor(const WebCursor& cursor);
gfx::Point TransformPointToRootCoordSpace(const gfx::Point& point,
- cc::SurfaceId surface_id);
+ const cc::SurfaceId& surface_id);
+ // TransformPointToLocalCoordSpace() can only transform points between
+ // surfaces where one is embedded (not necessarily directly) within the
+ // other. For points that can be in sibling surfaces, they must first be
+ // converted to the root surface's coordinate space.
+ gfx::Point TransformPointToLocalCoordSpace(
+ const gfx::Point& point,
+ const cc::SurfaceId& original_surface,
+ const cc::SurfaceId& local_surface_id);
+ gfx::Point TransformPointToCoordSpaceForView(
+ const gfx::Point& point,
+ RenderWidgetHostViewBase* target_view,
+ const cc::SurfaceId& local_surface_id);
+
// Pass acked touch events to the root view for gesture processing.
void ForwardProcessAckedTouchEvent(const TouchEventWithLatencyInfo& touch,
InputEventAckState ack_result);
« no previous file with comments | « cc/surfaces/surface_hittest.cc ('k') | content/browser/frame_host/cross_process_frame_connector.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698