Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1096)

Unified Diff: content/browser/frame_host/render_widget_host_view_child_frame.cc

Issue 2184033003: Refactor browser process coordinate transformation methods (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: nasko comments addressed Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/frame_host/render_widget_host_view_child_frame.cc
diff --git a/content/browser/frame_host/render_widget_host_view_child_frame.cc b/content/browser/frame_host/render_widget_host_view_child_frame.cc
index 1b064e30b2d30837b37c40caf07625b429c62631..3426797c7d9ce4b34a59ade99211cf710d847fb8 100644
--- a/content/browser/frame_host/render_widget_host_view_child_frame.cc
+++ b/content/browser/frame_host/render_widget_host_view_child_frame.cc
@@ -306,6 +306,12 @@ void RenderWidgetHostViewChildFrame::UnlockCompositingSurface() {
NOTIMPLEMENTED();
}
+RenderWidgetHostViewBase* RenderWidgetHostViewChildFrame::GetParentView() {
+ if (!frame_connector_)
+ return nullptr;
+ return frame_connector_->GetParentRenderWidgetHostView();
+}
+
void RenderWidgetHostViewChildFrame::RegisterSurfaceNamespaceId() {
// If Destroy() has been called before we get here, host_ may be null.
if (host_ && host_->delegate() && host_->delegate()->GetInputEventRouter()) {
@@ -522,6 +528,26 @@ gfx::Point RenderWidgetHostViewChildFrame::TransformPointToRootCoordSpace(
return frame_connector_->TransformPointToRootCoordSpace(point, surface_id_);
}
+gfx::Point RenderWidgetHostViewChildFrame::TransformPointToLocalCoordSpace(
+ const gfx::Point& point,
+ const cc::SurfaceId& original_surface) {
+ if (!frame_connector_ || surface_id_.is_null())
+ return point;
+
+ return frame_connector_->TransformPointToLocalCoordSpace(
+ point, original_surface, surface_id_);
+}
+
+gfx::Point RenderWidgetHostViewChildFrame::TransformPointToCoordSpaceForView(
+ const gfx::Point& point,
+ RenderWidgetHostViewBase* target_view) {
+ if (!frame_connector_ || surface_id_.is_null() || target_view == this)
+ return point;
+
+ return frame_connector_->TransformPointToCoordSpaceForView(point, target_view,
+ surface_id_);
lfg 2016/07/28 19:58:58 nit: indent.
kenrb 2016/07/28 21:19:08 Same as others.
+}
+
#if defined(OS_MACOSX)
ui::AcceleratedWidgetMac*
RenderWidgetHostViewChildFrame::GetAcceleratedWidgetMac() const {

Powered by Google App Engine
This is Rietveld 408576698