Source/core/css/CSSSelector.h - Issue 218403012: Check for null selectors when looping in findBestRuleSetAndAdd

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/css/CSSSelector.h

Issue 218403012: Check for null selectors when looping in findBestRuleSetAndAdd (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Addressed comments from ojan@. Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/css/CSSSelector.h

diff --git a/Source/core/css/CSSSelector.h b/Source/core/css/CSSSelector.h

index 00e155131e168b95429cb69e3e6a9498f1e83c57..d9c9933b5eb282626bcf6e84a532f724c6d6ede3 100644

--- a/Source/core/css/CSSSelector.h

+++ b/Source/core/css/CSSSelector.h

@@ -288,7 +288,7 @@ namespace WebCore {

bool isShadowPseudoElement() const;

bool isHostPseudoClass() const;

- // FIXME: selectors with no tagHistory() get a relation() of Descendant. It should instead be

+ // FIXME: selectors with no tagHistory() get a relation() of Descendant (and sometimes even SubSelector). It should instead be

// None.

Relation relation() const { return static_cast<Relation>(m_relation); }

« no previous file with comments | « LayoutTests/fast/css/inputtext-crash-expected.txt ('k') | Source/core/css/CSSSelector.cpp » ('j') | no next file with comments »