Issue 218403011: Adding msvs2013 support to scons.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 218403011: Adding msvs2013 support to scons. (Closed)

Created:
6 years, 8 months ago by bradn

Modified:
6 years, 8 months ago

Reviewers:
jvoung (off chromium)

CC:
native-client-reviews_googlegroups.com

Base URL:
https://chromium.googlesource.com/native_client/src/third_party.git@master

Visibility:
Public.

More Reviews

Description

Adding msvs2013 support to scons. Rather than absorb the risk of a scons upgrade at this moment, patching scons to support msvs2013, so that we can use our new 32-bit trybots. BUG=http://code.google.com/p/chromium/issues/detail?id=357183 TEST=local on bot R=jvoung@chromium.org Committed: 12970

Patch Set 1 #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -1 line)			Patch
	M	scons-2.0.1/README.nacl	View		1 chunk	+3 lines, -0 lines	0 comments	Download
	M	scons-2.0.1/engine/SCons/Tool/MSCommon/vc.py	View		1 chunk	+3 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

jvoung (off chromium)

LGTM, any idea what version will have the actual fix? I see in the source ...

6 years, 8 months ago (2014-04-01 21:02:33 UTC) #2

bradn

Not sure exactly. At some point would should probably just upgrade to the latest version. ...

6 years, 8 months ago (2014-04-01 21:17:37 UTC) #3

bradn

6 years, 8 months ago (2014-04-01 21:23:18 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r12970 (presubmit successful).

Expand Messages | Collapse Messages