src/lithium-codegen.h - Issue 218403006: Check that environments assigned via AssignEnvironment are actually used.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/lithium-codegen.h

Issue 218403006: Check that environments assigned via AssignEnvironment are actually used. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Simplified. Rebased. Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/lithium-codegen.h

diff --git a/src/lithium-codegen.h b/src/lithium-codegen.h

index 3e8d471ea78deb92f7f5647dd59cebd116f5ffd6..9f06781b852a0800b72602489a475bb2333eac58 100644

--- a/src/lithium-codegen.h

+++ b/src/lithium-codegen.h

@@ -68,6 +68,11 @@ class LCodeGenBase BASE_EMBEDDED {

void RegisterWeakObjectsInOptimizedCode(Handle<Code> code);

+ // Check that an environment assigned via AssignEnvironment is actually being

+ // used. Redundant assignments keep things alive longer than necessary, and

+ // consequently lead to worse code, so it's important to minimize this.

+ void CheckEnvironmentUsage();

protected:

enum Status {

UNUSED,

« no previous file with comments | « src/lithium.cc ('k') | src/lithium-codegen.cc » ('j') | no next file with comments »