Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(232)

Side by Side Diff: src/ia32/lithium-codegen-ia32.cc

Issue 218403006: Check that environments assigned via AssignEnvironment are actually used. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Simplified. Rebased. Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/arm64/lithium-codegen-arm64.cc ('k') | src/ia32/lithium-ia32.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1033 matching lines...) Expand 10 before | Expand all | Expand 10 after
1044 __ CallRuntimeSaveDoubles(id); 1044 __ CallRuntimeSaveDoubles(id);
1045 RecordSafepointWithRegisters( 1045 RecordSafepointWithRegisters(
1046 instr->pointer_map(), argc, Safepoint::kNoLazyDeopt); 1046 instr->pointer_map(), argc, Safepoint::kNoLazyDeopt);
1047 1047
1048 ASSERT(info()->is_calling()); 1048 ASSERT(info()->is_calling());
1049 } 1049 }
1050 1050
1051 1051
1052 void LCodeGen::RegisterEnvironmentForDeoptimization( 1052 void LCodeGen::RegisterEnvironmentForDeoptimization(
1053 LEnvironment* environment, Safepoint::DeoptMode mode) { 1053 LEnvironment* environment, Safepoint::DeoptMode mode) {
1054 environment->set_has_been_used();
1054 if (!environment->HasBeenRegistered()) { 1055 if (!environment->HasBeenRegistered()) {
1055 // Physical stack frame layout: 1056 // Physical stack frame layout:
1056 // -x ............. -4 0 ..................................... y 1057 // -x ............. -4 0 ..................................... y
1057 // [incoming arguments] [spill slots] [pushed outgoing arguments] 1058 // [incoming arguments] [spill slots] [pushed outgoing arguments]
1058 1059
1059 // Layout of the environment: 1060 // Layout of the environment:
1060 // 0 ..................................................... size-1 1061 // 0 ..................................................... size-1
1061 // [parameters] [locals] [expression stack including arguments] 1062 // [parameters] [locals] [expression stack including arguments]
1062 1063
1063 // Layout of the translation: 1064 // Layout of the translation:
(...skipping 5373 matching lines...) Expand 10 before | Expand all | Expand 10 after
6437 __ bind(deferred->exit()); 6438 __ bind(deferred->exit());
6438 __ bind(&done); 6439 __ bind(&done);
6439 } 6440 }
6440 6441
6441 6442
6442 #undef __ 6443 #undef __
6443 6444
6444 } } // namespace v8::internal 6445 } } // namespace v8::internal
6445 6446
6446 #endif // V8_TARGET_ARCH_IA32 6447 #endif // V8_TARGET_ARCH_IA32
OLDNEW
« no previous file with comments | « src/arm64/lithium-codegen-arm64.cc ('k') | src/ia32/lithium-ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698