Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(496)

Unified Diff: third_party/libjingle/overrides/talk/base/logging.cc

Issue 218403004: Fix the timestamp generation for webrtc native log. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/libjingle/overrides/talk/base/logging.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/libjingle/overrides/talk/base/logging.cc
diff --git a/third_party/libjingle/overrides/talk/base/logging.cc b/third_party/libjingle/overrides/talk/base/logging.cc
index 3e471817d737af6b8be9c392ae7fc4aad88f7db9..8553de863d08da4d915d56aa695797c911bba738 100644
--- a/third_party/libjingle/overrides/talk/base/logging.cc
+++ b/third_party/libjingle/overrides/talk/base/logging.cc
@@ -132,7 +132,6 @@ DiagnosticLogMessage::DiagnosticLogMessage(const char* file,
severity_(severity),
log_to_chrome_(log_to_chrome) {
extra_ = GenerateExtra(err_ctx, err, NULL);
- CreateTimestamp();
}
DiagnosticLogMessage::DiagnosticLogMessage(const char* file,
@@ -147,7 +146,6 @@ DiagnosticLogMessage::DiagnosticLogMessage(const char* file,
severity_(severity),
log_to_chrome_(log_to_chrome) {
extra_ = GenerateExtra(err_ctx, err, module);
- CreateTimestamp();
}
DiagnosticLogMessage::~DiagnosticLogMessage() {
@@ -156,22 +154,10 @@ DiagnosticLogMessage::~DiagnosticLogMessage() {
if (log_to_chrome_)
LOG_LAZY_STREAM_DIRECT(file_name_, line_, severity_) << str;
if (g_logging_delegate_function && severity_ <= LS_INFO) {
- print_stream_with_timestamp_ << str;
- g_logging_delegate_function(print_stream_with_timestamp_.str());
+ g_logging_delegate_function(str);
}
}
-void DiagnosticLogMessage::CreateTimestamp() {
-#if !defined(ANDROID)
- static const uint32 g_logging_start_time = talk_base::Time();
- uint32 time = talk_base::TimeSince(g_logging_start_time);
- print_stream_with_timestamp_ << "[" << std::setfill('0')
- << std::setw(3) << (time / 1000)
- << ":" << std::setw(3) << (time % 1000)
- << std::setfill(' ') << "] ";
-#endif
-}
-
// Note: this function is a copy from the overriden libjingle implementation.
void LogMultiline(LoggingSeverity level, const char* label, bool input,
const void* data, size_t len, bool hex_mode,
« no previous file with comments | « third_party/libjingle/overrides/talk/base/logging.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698