Issue 218403002: Fix Type::Intersect to allocate large enough union.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 218403002: Fix Type::Intersect to allocate large enough union.

Created:
6 years, 8 months ago by Jakob Kummerow

Modified:
6 years, 8 months ago

Reviewers:
rossberg

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Fix Type::Intersect to allocate large enough union. Related cleanup: use List::Set(i, val) instead of List::at(i) = val. BUG=chromium:357330 LOG=y

Patch Set 1 #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+61 lines, -56 lines)			Patch
M	src/global-handles.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/heap-snapshot-generator.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/hydrogen-instructions.cc	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/jsregexp.cc	View	8 chunks	+10 lines, -10 lines	0 comments	Download
M	src/parser.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/types.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/types.cc	View	4 chunks	+36 lines, -30 lines	0 comments	Download
A +	test/mjsunit/regress/regress-crbug-357330.js	View	1 chunk	+9 lines, -12 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

rossberg

6 years, 8 months ago (2014-03-31 13:17:58 UTC) #2

On 2014/03/29 23:14:24, Jakob wrote:
> PTAL. Does this fix make sense?

It fixes the symptoms, but not the root bug, which was that the comparisons
"bitset != kNone" should have been refined to IsInhabited(bitset) when I
introduced representation types.

I fixed it here, reusing parts of your CL for clean-up:

https://codereview.chromium.org/219333003/

Expand Messages | Collapse Messages