Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Side by Side Diff: components/scheduler/renderer/task_duration_reporter.cc

Issue 2184023002: Report the duration of sampled tasks with histogram. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Formatting, comment, and typo.. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #include "components/scheduler/renderer/task_duration_reporter.h"
6
7 #include "base/metrics/histogram_macros.h"
8
9 namespace scheduler {
10 namespace {
11 const int kSampleInterval = 100;
tdresser 2016/07/27 18:04:25 This shouldn't be indented, should it? Play around
sunyunjia 2016/07/27 19:51:04 Done.
12 }
13
14 TaskDurationReporter::TaskDurationReporter() : sample_count_(0) {}
majidvp 2016/07/27 18:34:02 nit: same as above. Should not be indented.
sunyunjia 2016/07/27 19:51:04 Done.
15
16 TaskDurationReporter::~TaskDurationReporter() {}
17
18 void TaskDurationReporter::ReportSampleDuration(base::TimeDelta duration) {
19 ++sample_count_;
20 if (sample_count_ == kSampleInterval) {
21 // [1msec ~ 10sec], 50 bins. All tasks longer than 10sec will be put into
22 // the same bin.
23 UMA_HISTOGRAM_TIMES("RendererScheduler.TaskDuration", duration);
tdresser 2016/07/27 18:04:25 For input latency, we use UMA_HISTOGRAM_CUSTOM_C
sunyunjia 2016/07/27 19:51:04 Done.
24 sample_count_ = 0;
25 }
26 }
27 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698